2015-10-11 05:41:23 -04:00
|
|
|
require 'rails_helper'
|
2014-09-23 01:50:26 -04:00
|
|
|
|
|
|
|
require_dependency 'jobs/scheduled/clean_up_uploads'
|
|
|
|
|
|
|
|
describe Jobs::CleanUpUploads do
|
2016-08-01 12:35:57 -04:00
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
def fabricate_upload(attributes = {})
|
|
|
|
Fabricate(:upload, { created_at: 2.hours.ago }.merge(attributes))
|
2016-08-01 12:35:57 -04:00
|
|
|
end
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
let(:upload) { fabricate_upload }
|
|
|
|
|
2016-06-20 16:05:41 -04:00
|
|
|
before do
|
2014-09-23 01:50:26 -04:00
|
|
|
SiteSetting.clean_up_uploads = true
|
2016-06-20 16:05:41 -04:00
|
|
|
SiteSetting.clean_orphan_uploads_grace_period_hours = 1
|
2016-08-01 12:35:57 -04:00
|
|
|
@upload = fabricate_upload
|
2016-06-20 16:05:41 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "deletes orphan uploads" do
|
2018-06-04 22:03:26 -04:00
|
|
|
expect do
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
end.to change { Upload.count }.by(-1)
|
2016-06-20 16:05:41 -04:00
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'when clean_up_uploads is disabled' do
|
|
|
|
before do
|
|
|
|
SiteSetting.clean_up_uploads = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should still delete invalid upload records' do
|
|
|
|
upload2 = fabricate_upload(
|
|
|
|
url: "",
|
|
|
|
retain_hours: nil
|
|
|
|
)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
end.to change { Upload.count }.by(-1)
|
2016-06-20 16:05:41 -04:00
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: upload2.id)).to eq(false)
|
|
|
|
end
|
2014-09-23 01:50:26 -04:00
|
|
|
end
|
2016-06-20 16:05:41 -04:00
|
|
|
|
2018-11-14 02:03:02 -05:00
|
|
|
it 'does not clean up upload site settings' do
|
|
|
|
begin
|
|
|
|
original_provider = SiteSetting.provider
|
|
|
|
SiteSetting.provider = SiteSettings::DbProvider.new(SiteSetting)
|
|
|
|
|
|
|
|
logo_upload = fabricate_upload
|
|
|
|
logo_small_upload = fabricate_upload
|
|
|
|
digest_logo_upload = fabricate_upload
|
|
|
|
mobile_logo_upload = fabricate_upload
|
|
|
|
large_icon_upload = fabricate_upload
|
|
|
|
opengraph_image_upload = fabricate_upload
|
|
|
|
twitter_summary_large_image_upload = fabricate_upload
|
|
|
|
favicon_upload = fabricate_upload
|
|
|
|
apple_touch_icon_upload = fabricate_upload
|
|
|
|
|
|
|
|
SiteSetting.logo = logo_upload
|
|
|
|
SiteSetting.logo_small = logo_small_upload
|
|
|
|
SiteSetting.digest_logo = digest_logo_upload
|
|
|
|
SiteSetting.mobile_logo = mobile_logo_upload
|
|
|
|
SiteSetting.large_icon = large_icon_upload
|
|
|
|
SiteSetting.opengraph_image = opengraph_image_upload
|
|
|
|
|
|
|
|
SiteSetting.twitter_summary_large_image =
|
|
|
|
twitter_summary_large_image_upload
|
|
|
|
|
|
|
|
SiteSetting.favicon = favicon_upload
|
|
|
|
SiteSetting.apple_touch_icon = apple_touch_icon_upload
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
|
|
|
[
|
|
|
|
logo_upload,
|
|
|
|
logo_small_upload,
|
|
|
|
digest_logo_upload,
|
|
|
|
mobile_logo_upload,
|
|
|
|
large_icon_upload,
|
|
|
|
opengraph_image_upload,
|
|
|
|
twitter_summary_large_image_upload,
|
|
|
|
favicon_upload,
|
|
|
|
apple_touch_icon_upload
|
|
|
|
].each { |record| expect(Upload.exists?(id: record.id)).to eq(true) }
|
|
|
|
ensure
|
|
|
|
SiteSetting.delete_all
|
|
|
|
SiteSetting.provider = original_provider
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not clean up uploads with URLs used in site settings" do
|
2016-09-08 16:58:07 -04:00
|
|
|
logo_upload = fabricate_upload
|
2018-07-18 06:57:43 -04:00
|
|
|
logo_small_upload = fabricate_upload
|
2018-11-12 20:15:16 -05:00
|
|
|
digest_logo_upload = fabricate_upload
|
|
|
|
mobile_logo_upload = fabricate_upload
|
|
|
|
large_icon_upload = fabricate_upload
|
|
|
|
default_opengraph_image_upload = fabricate_upload
|
|
|
|
twitter_summary_large_image_upload = fabricate_upload
|
2018-07-18 06:57:43 -04:00
|
|
|
favicon_upload = fabricate_upload
|
|
|
|
apple_touch_icon_upload = fabricate_upload
|
|
|
|
avatar1_upload = fabricate_upload
|
|
|
|
avatar2_upload = fabricate_upload
|
|
|
|
|
2016-09-08 16:58:07 -04:00
|
|
|
SiteSetting.logo_url = logo_upload.url
|
2018-07-18 06:57:43 -04:00
|
|
|
SiteSetting.logo_small_url = logo_small_upload.url
|
2018-11-12 20:15:16 -05:00
|
|
|
SiteSetting.digest_logo_url = digest_logo_upload.url
|
|
|
|
SiteSetting.mobile_logo_url = mobile_logo_upload.url
|
|
|
|
SiteSetting.large_icon_url = large_icon_upload.url
|
|
|
|
SiteSetting.default_opengraph_image_url = default_opengraph_image_upload.url
|
|
|
|
|
|
|
|
SiteSetting.twitter_summary_large_image_url =
|
|
|
|
twitter_summary_large_image_upload.url
|
|
|
|
|
2018-07-18 06:57:43 -04:00
|
|
|
SiteSetting.favicon_url = favicon_upload.url
|
|
|
|
SiteSetting.apple_touch_icon_url = apple_touch_icon_upload.url
|
|
|
|
SiteSetting.selectable_avatars = [avatar1_upload.url, avatar2_upload.url].join("\n")
|
2016-09-08 16:58:07 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: logo_upload.id)).to eq(true)
|
2018-07-18 06:57:43 -04:00
|
|
|
expect(Upload.exists?(id: logo_small_upload.id)).to eq(true)
|
2018-11-12 20:15:16 -05:00
|
|
|
expect(Upload.exists?(id: digest_logo_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: mobile_logo_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: large_icon_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: default_opengraph_image_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: twitter_summary_large_image_upload.id)).to eq(true)
|
2018-07-18 06:57:43 -04:00
|
|
|
expect(Upload.exists?(id: favicon_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: apple_touch_icon_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: avatar1_upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: avatar2_upload.id)).to eq(true)
|
2016-09-08 16:58:07 -04:00
|
|
|
end
|
|
|
|
|
2017-06-07 16:53:15 -04:00
|
|
|
it "does not clean up uploads in site settings when they use the CDN" do
|
|
|
|
Discourse.stubs(:asset_host).returns("//my.awesome.cdn")
|
|
|
|
|
|
|
|
logo_small_upload = fabricate_upload
|
|
|
|
SiteSetting.logo_small_url = "#{Discourse.asset_host}#{logo_small_upload.url}"
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: logo_small_upload.id)).to eq(true)
|
2017-06-07 16:53:15 -04:00
|
|
|
end
|
|
|
|
|
2016-07-01 03:22:30 -04:00
|
|
|
it "does not delete profile background uploads" do
|
2016-08-01 12:35:57 -04:00
|
|
|
profile_background_upload = fabricate_upload
|
2016-07-01 03:22:30 -04:00
|
|
|
UserProfile.last.update_attributes!(profile_background: profile_background_upload.url)
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: profile_background_upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete card background uploads" do
|
2016-08-01 12:35:57 -04:00
|
|
|
card_background_upload = fabricate_upload
|
2016-07-01 03:22:30 -04:00
|
|
|
UserProfile.last.update_attributes!(card_background: card_background_upload.url)
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: card_background_upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete category logo uploads" do
|
2016-08-01 12:35:57 -04:00
|
|
|
category_logo_upload = fabricate_upload
|
2016-12-02 02:15:34 -05:00
|
|
|
Fabricate(:category, uploaded_logo: category_logo_upload)
|
2016-07-01 03:22:30 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: category_logo_upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete category background url uploads" do
|
2016-12-02 02:15:34 -05:00
|
|
|
category_logo_upload = fabricate_upload
|
|
|
|
Fabricate(:category, uploaded_background: category_logo_upload)
|
2016-07-01 03:22:30 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: category_logo_upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete post uploads" do
|
2016-08-01 12:35:57 -04:00
|
|
|
upload = fabricate_upload
|
2016-09-08 16:58:07 -04:00
|
|
|
Fabricate(:post, uploads: [upload])
|
2016-07-01 03:22:30 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete user uploaded avatar" do
|
2016-08-01 12:35:57 -04:00
|
|
|
upload = fabricate_upload
|
2016-09-08 16:58:07 -04:00
|
|
|
Fabricate(:user, uploaded_avatar: upload)
|
2016-07-01 03:22:30 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete user gravatar" do
|
2016-08-01 12:35:57 -04:00
|
|
|
upload = fabricate_upload
|
2016-09-08 16:58:07 -04:00
|
|
|
Fabricate(:user, user_avatar: Fabricate(:user_avatar, gravatar_upload: upload))
|
2016-07-01 03:22:30 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
2016-07-01 03:22:30 -04:00
|
|
|
end
|
2016-08-01 12:35:57 -04:00
|
|
|
|
2016-11-01 23:14:02 -04:00
|
|
|
it "does not delete user custom upload" do
|
|
|
|
upload = fabricate_upload
|
|
|
|
Fabricate(:user, user_avatar: Fabricate(:user_avatar, custom_upload: upload))
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
2016-11-01 23:14:02 -04:00
|
|
|
end
|
|
|
|
|
2016-08-01 12:35:57 -04:00
|
|
|
it "does not delete uploads in a queued post" do
|
|
|
|
upload = fabricate_upload
|
2017-11-13 09:01:31 -05:00
|
|
|
upload2 = fabricate_upload
|
2016-08-01 12:35:57 -04:00
|
|
|
|
|
|
|
QueuedPost.create(
|
|
|
|
queue: "uploads",
|
|
|
|
state: QueuedPost.states[:new],
|
|
|
|
user_id: Fabricate(:user).id,
|
2017-11-13 09:01:31 -05:00
|
|
|
raw: "#{upload.sha1}\n#{upload2.short_url}",
|
2016-08-01 12:35:57 -04:00
|
|
|
post_options: {}
|
|
|
|
)
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: upload2.id)).to eq(true)
|
2016-08-01 12:35:57 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not delete uploads in a draft" do
|
|
|
|
upload = fabricate_upload
|
2017-11-13 09:01:31 -05:00
|
|
|
upload2 = fabricate_upload
|
|
|
|
|
|
|
|
Draft.set(Fabricate(:user), "test", 0, "#{upload.sha1}\n#{upload2.short_url}")
|
2016-08-01 12:35:57 -04:00
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
|
|
|
expect(Upload.exists?(id: upload2.id)).to eq(true)
|
2016-08-01 12:35:57 -04:00
|
|
|
end
|
|
|
|
|
2017-02-02 04:41:57 -05:00
|
|
|
it "does not delete custom emojis" do
|
|
|
|
upload = fabricate_upload
|
|
|
|
CustomEmoji.create!(name: 'test', upload: upload)
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: upload.id)).to eq(true)
|
2017-02-02 04:41:57 -05:00
|
|
|
end
|
|
|
|
|
2018-04-19 07:30:31 -04:00
|
|
|
it "does not delete user exported csv uploads" do
|
|
|
|
csv_file = fabricate_upload
|
|
|
|
UserExport.create(file_name: "export.csv", user_id: Fabricate(:user).id, upload_id: csv_file.id)
|
|
|
|
|
|
|
|
Jobs::CleanUpUploads.new.execute(nil)
|
|
|
|
|
2018-06-04 22:03:26 -04:00
|
|
|
expect(Upload.exists?(id: @upload.id)).to eq(false)
|
|
|
|
expect(Upload.exists?(id: csv_file.id)).to eq(true)
|
2018-04-19 07:30:31 -04:00
|
|
|
end
|
2014-09-23 01:50:26 -04:00
|
|
|
end
|