discourse/app/jobs/scheduled/clean_up_deprecated_url_sit...

# frozen_string_literal: true

module Jobs
  class CleanUpDeprecatedUrlSiteSettings < ::Jobs::Scheduled
    every 1.day

    def execute(args)
      ::Jobs::MigrateUrlSiteSettings::SETTINGS.each do |old_setting, new_setting|
        if SiteSetting.where("name = ? AND value IS NOT NULL", new_setting).exists?
          SiteSetting.set(old_setting, nil, warn: false)
          SiteSetting.find_by(name: old_setting).destroy!
        end
      end
    end
  end
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-02 18:17:27 -04:00			`# frozen_string_literal: true`

FIX: Job to clean up old URL settings when new setting has been set. Related to https://github.com/discourse/discourse/commit/44391ee8ab7431ca572b6c340d6e770cdadd51b3 2018-11-15 20:19:58 -05:00			`module Jobs`
DEV: Upgrading Discourse to Zeitwerk (#8098) Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains. We no longer need to use Rails "require_dependency" anywhere and instead can just use standard Ruby patterns to require files. This is a far reaching change and we expect some followups here. 2019-10-02 00:01:53 -04:00			`class CleanUpDeprecatedUrlSiteSettings < ::Jobs::Scheduled`
FIX: Job to clean up old URL settings when new setting has been set. Related to https://github.com/discourse/discourse/commit/44391ee8ab7431ca572b6c340d6e770cdadd51b3 2018-11-15 20:19:58 -05:00			`every 1.day`

			`def execute(args)`
FIX: Zeitwerk-related fixes for jobs. (#8187) 2019-10-14 06:03:22 -04:00			`::Jobs::MigrateUrlSiteSettings::SETTINGS.each do \|old_setting, new_setting\|`
FIX: Job to clean up old URL settings when new setting has been set. Related to https://github.com/discourse/discourse/commit/44391ee8ab7431ca572b6c340d6e770cdadd51b3 2018-11-15 20:19:58 -05:00			`if SiteSetting.where("name = ? AND value IS NOT NULL", new_setting).exists?`
DEV: introduce new API to look up dynamic site setting This removes all uses of both `send` and `public_send` from consumers of SiteSetting and instead introduces a `get` helper for dynamic lookup This leads to much cleaner and safer code long term as we are always explicit to test that a site setting is really there before sending an arbitrary string to the class It also removes a couple of risky stubs from the auth provider test 2019-05-06 21:00:09 -04:00			`SiteSetting.set(old_setting, nil, warn: false)`
FIX: Remove site settings override for deprecated url site settings. 2018-11-19 22:42:39 -05:00			`SiteSetting.find_by(name: old_setting).destroy!`
FIX: Job to clean up old URL settings when new setting has been set. Related to https://github.com/discourse/discourse/commit/44391ee8ab7431ca572b6c340d6e770cdadd51b3 2018-11-15 20:19:58 -05:00			`end`
			`end`
			`end`
			`end`
			`end`