2021-02-09 00:33:14 -05:00
|
|
|
#!/usr/bin/env ruby
|
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'pathname'
|
|
|
|
|
|
|
|
RAILS_ROOT = File.expand_path("../../", Pathname.new(__FILE__).realpath)
|
2021-04-29 14:13:36 -04:00
|
|
|
PORT = ENV["UNICORN_PORT"] ||= "3000"
|
2021-11-09 15:55:43 -05:00
|
|
|
HOSTNAME = ENV["DISCOURSE_HOSTNAME"] ||= "127.0.0.1"
|
2022-06-28 15:20:14 -04:00
|
|
|
YARN_DIR = File.join(RAILS_ROOT, "app/assets/javascripts/discourse")
|
DEV: Minimal first pass of rails system test setup (#16311)
This commit introduces rails system tests run with chromedriver, selenium,
and headless chrome to our testing toolbox.
We use the `webdrivers` gem and `selenium-webdriver` which is what
the latest Rails uses so the tests run locally and in CI out of the box.
You can use `SELENIUM_VERBOSE_DRIVER_LOGS=1` to show extra
verbose logs of what selenium is doing to communicate with the system
tests.
By default JS logs are verbose so errors from JS are shown when
running system tests, you can disable this with
`SELENIUM_DISABLE_VERBOSE_JS_LOGS=1`
You can use `SELENIUM_HEADLESS=0` to run the system
tests inside a chrome browser instead of headless, which can be useful to debug things
and see what the spec sees. See note above about `bin/ember-cli` to avoid
surprises.
I have modified `bin/turbo_rspec` to exclude `spec/system` by default,
support for parallel system specs is a little shaky right now and we don't
want them slowing down the turbo by default either.
### PageObjects and System Tests
To make querying and inspecting parts of the page easier
and more reusable inbetween system tests, we are using the
concept of [PageObjects](https://www.selenium.dev/documentation/test_practices/encouraged/page_object_models/) in
our system tests. A "Page" here is generally corresponds to
an overarching ember route, e.g. "Topic" for `/t/324345/some-topic`,
and this contains logic for querying components within the topic
such as "Posts".
I have also split "Modals" into their own entity. Further down the
line we may want to explore creating independent "Component"
contexts.
Capybara DSL should be included in each PageObject class,
reference for this can be found at https://rubydoc.info/github/teamcapybara/capybara/master#the-dsl
For system tests, since they are so slow, we want to focus on
the "happy path" and not do every different possible context
and branch check using them. They are meant to be overarching
tests that check a number of things are correct using the full stack
from JS and ember to rails to ruby and then the database.
### CI Setup
Whenever a system spec fails, a screenshot
is taken and a build artifact is produced _after the entire CI run is complete_,
which can be downloaded from the Actions UI in the repo.
Most importantly, a step to build the Ember app using Ember CLI
is needed, otherwise the JS assets cannot be found by capybara:
```
- name: Build Ember CLI
run: bin/ember-cli --build
```
A new `--build` argument has been added to `bin/ember-cli` for this
case, which is not needed locally if you already have the discourse
rails server running via `bin/ember-cli -u` since the whole server is built and
set up by default.
Co-authored-by: David Taylor <david@taylorhq.com>
2022-09-27 21:48:16 -04:00
|
|
|
CUSTOM_ARGS = ["--try", "--test", "--build", "--unicorn", "-u", "--forward-host"]
|
2021-02-09 00:33:14 -05:00
|
|
|
PROXY =
|
|
|
|
if ARGV.include?("--try")
|
|
|
|
"https://try.discourse.org"
|
|
|
|
else
|
2021-11-02 23:26:44 -04:00
|
|
|
"http://#{HOSTNAME}:#{PORT}"
|
2021-02-09 00:33:14 -05:00
|
|
|
end
|
|
|
|
|
2022-09-02 17:51:51 -04:00
|
|
|
def process_running?(pid)
|
|
|
|
!!Process.kill(0, pid)
|
|
|
|
rescue Errno::ESRCH
|
|
|
|
false
|
|
|
|
end
|
|
|
|
|
2021-05-10 09:34:24 -04:00
|
|
|
command =
|
|
|
|
if ARGV.include?("--test")
|
|
|
|
"test"
|
DEV: Minimal first pass of rails system test setup (#16311)
This commit introduces rails system tests run with chromedriver, selenium,
and headless chrome to our testing toolbox.
We use the `webdrivers` gem and `selenium-webdriver` which is what
the latest Rails uses so the tests run locally and in CI out of the box.
You can use `SELENIUM_VERBOSE_DRIVER_LOGS=1` to show extra
verbose logs of what selenium is doing to communicate with the system
tests.
By default JS logs are verbose so errors from JS are shown when
running system tests, you can disable this with
`SELENIUM_DISABLE_VERBOSE_JS_LOGS=1`
You can use `SELENIUM_HEADLESS=0` to run the system
tests inside a chrome browser instead of headless, which can be useful to debug things
and see what the spec sees. See note above about `bin/ember-cli` to avoid
surprises.
I have modified `bin/turbo_rspec` to exclude `spec/system` by default,
support for parallel system specs is a little shaky right now and we don't
want them slowing down the turbo by default either.
### PageObjects and System Tests
To make querying and inspecting parts of the page easier
and more reusable inbetween system tests, we are using the
concept of [PageObjects](https://www.selenium.dev/documentation/test_practices/encouraged/page_object_models/) in
our system tests. A "Page" here is generally corresponds to
an overarching ember route, e.g. "Topic" for `/t/324345/some-topic`,
and this contains logic for querying components within the topic
such as "Posts".
I have also split "Modals" into their own entity. Further down the
line we may want to explore creating independent "Component"
contexts.
Capybara DSL should be included in each PageObject class,
reference for this can be found at https://rubydoc.info/github/teamcapybara/capybara/master#the-dsl
For system tests, since they are so slow, we want to focus on
the "happy path" and not do every different possible context
and branch check using them. They are meant to be overarching
tests that check a number of things are correct using the full stack
from JS and ember to rails to ruby and then the database.
### CI Setup
Whenever a system spec fails, a screenshot
is taken and a build artifact is produced _after the entire CI run is complete_,
which can be downloaded from the Actions UI in the repo.
Most importantly, a step to build the Ember app using Ember CLI
is needed, otherwise the JS assets cannot be found by capybara:
```
- name: Build Ember CLI
run: bin/ember-cli --build
```
A new `--build` argument has been added to `bin/ember-cli` for this
case, which is not needed locally if you already have the discourse
rails server running via `bin/ember-cli -u` since the whole server is built and
set up by default.
Co-authored-by: David Taylor <david@taylorhq.com>
2022-09-27 21:48:16 -04:00
|
|
|
elsif ARGV.include?("--build")
|
|
|
|
"build"
|
2021-05-10 09:34:24 -04:00
|
|
|
else
|
|
|
|
"server"
|
|
|
|
end
|
|
|
|
|
|
|
|
class String
|
|
|
|
def cyan
|
|
|
|
"\e[36m#{self}\e[0m"
|
|
|
|
end
|
2021-11-24 15:16:33 -05:00
|
|
|
|
|
|
|
def red
|
|
|
|
"\033[31m#{self}\e[0m"
|
|
|
|
end
|
2021-05-10 09:34:24 -04:00
|
|
|
end
|
|
|
|
|
2021-02-09 00:33:14 -05:00
|
|
|
if ARGV.include?("-h") || ARGV.include?("--help")
|
|
|
|
puts "ember-cli OPTIONS"
|
2021-06-08 22:44:33 -04:00
|
|
|
puts "#{"--try".cyan} To proxy try.discourse.org"
|
|
|
|
puts "#{"--test".cyan} To run the test suite"
|
|
|
|
puts "#{"--unicorn, -u".cyan} To run a unicorn server as well"
|
2021-02-09 00:33:14 -05:00
|
|
|
puts "The rest of the arguments are passed to ember server per:", ""
|
2022-06-28 15:20:14 -04:00
|
|
|
exec "yarn -s --cwd #{YARN_DIR} run ember #{command} --help"
|
2021-02-09 00:33:14 -05:00
|
|
|
end
|
|
|
|
|
2022-06-28 15:20:14 -04:00
|
|
|
args = ["-s", "--cwd", YARN_DIR, "run", "ember", command] + (ARGV - CUSTOM_ARGS)
|
2021-02-09 00:33:14 -05:00
|
|
|
|
DEV: Minimal first pass of rails system test setup (#16311)
This commit introduces rails system tests run with chromedriver, selenium,
and headless chrome to our testing toolbox.
We use the `webdrivers` gem and `selenium-webdriver` which is what
the latest Rails uses so the tests run locally and in CI out of the box.
You can use `SELENIUM_VERBOSE_DRIVER_LOGS=1` to show extra
verbose logs of what selenium is doing to communicate with the system
tests.
By default JS logs are verbose so errors from JS are shown when
running system tests, you can disable this with
`SELENIUM_DISABLE_VERBOSE_JS_LOGS=1`
You can use `SELENIUM_HEADLESS=0` to run the system
tests inside a chrome browser instead of headless, which can be useful to debug things
and see what the spec sees. See note above about `bin/ember-cli` to avoid
surprises.
I have modified `bin/turbo_rspec` to exclude `spec/system` by default,
support for parallel system specs is a little shaky right now and we don't
want them slowing down the turbo by default either.
### PageObjects and System Tests
To make querying and inspecting parts of the page easier
and more reusable inbetween system tests, we are using the
concept of [PageObjects](https://www.selenium.dev/documentation/test_practices/encouraged/page_object_models/) in
our system tests. A "Page" here is generally corresponds to
an overarching ember route, e.g. "Topic" for `/t/324345/some-topic`,
and this contains logic for querying components within the topic
such as "Posts".
I have also split "Modals" into their own entity. Further down the
line we may want to explore creating independent "Component"
contexts.
Capybara DSL should be included in each PageObject class,
reference for this can be found at https://rubydoc.info/github/teamcapybara/capybara/master#the-dsl
For system tests, since they are so slow, we want to focus on
the "happy path" and not do every different possible context
and branch check using them. They are meant to be overarching
tests that check a number of things are correct using the full stack
from JS and ember to rails to ruby and then the database.
### CI Setup
Whenever a system spec fails, a screenshot
is taken and a build artifact is produced _after the entire CI run is complete_,
which can be downloaded from the Actions UI in the repo.
Most importantly, a step to build the Ember app using Ember CLI
is needed, otherwise the JS assets cannot be found by capybara:
```
- name: Build Ember CLI
run: bin/ember-cli --build
```
A new `--build` argument has been added to `bin/ember-cli` for this
case, which is not needed locally if you already have the discourse
rails server running via `bin/ember-cli -u` since the whole server is built and
set up by default.
Co-authored-by: David Taylor <david@taylorhq.com>
2022-09-27 21:48:16 -04:00
|
|
|
if !args.include?("test") && !args.include?("build") && !args.include?("--proxy")
|
2021-02-09 00:33:14 -05:00
|
|
|
args << "--proxy"
|
|
|
|
args << PROXY
|
|
|
|
end
|
|
|
|
|
DEV: Introduce feature-flag for Ember 5 upgrade
This commit introduces the scaffolding for us to easily switch between Ember 3.28 and Ember 5 on the `main` branch of Discourse. Unfortunately, there is no built-in system to apply this kind of flagging within yarn / ember-cli. There are projects like `ember-try` which are designed for running against multiple version of a dependency, but they do not allow us to 'lock' dependency/sub-dependency versions, and are therefore unsuitable for our use in production.
Instead, we will be maintaining two root `package.json` files, and two `yarn.lock` files. For ember-3, they remain as-is. For ember5, we use a yarn 'resolution' to override the version for ember-source across the entire yarn workspace.
To allow for easy switching with minimal diff against the repository, `package.json` and `yarn.lock` are symlinks which point to `package-ember3.json` and `yarn-ember3.lock` by default. To switch to Ember 5, we can run `script/switch ember version 5` to update the symlinks to point to `package-ember5.json` and `package-ember3.json` respectively. In production, and when using `bin/ember-cli` for development, the ember version can also be upgraded using the `EMBER_VERSION=5` environment variable.
When making changes to dependencies, these should be made against the default `ember3` versions, and then `script/regen_ember_5_lockfile` should be used to regenerate `yarn-ember5.lock` accordingly. A new 'Ember Version Lockfiles' GitHub workflow will automate this process on Dependabot PRs.
When running a local environment against Ember 5, the two symlink changes will show up as git diffs. To avoid us accidentally committing/pushing that change, another GitHub workflow is introduced which checks the default Ember version and raises an error if it is greater than v3.
Supporting two ember versions simultaneously obviously carries significant overhead, so our aim will be to get themes/plugins updated as quickly as possible, and then drop this flag.
2023-11-27 10:52:17 -05:00
|
|
|
if !["3", "5", nil].include?(ENV["EMBER_VERSION"])
|
|
|
|
raise "Unknown ember version #{ENV["EMBER_VERSION"]}"
|
|
|
|
end
|
|
|
|
|
|
|
|
system(
|
|
|
|
"script/switch_ember_version",
|
2024-01-10 07:12:36 -05:00
|
|
|
ENV["EMBER_VERSION"] || "5",
|
DEV: Introduce feature-flag for Ember 5 upgrade
This commit introduces the scaffolding for us to easily switch between Ember 3.28 and Ember 5 on the `main` branch of Discourse. Unfortunately, there is no built-in system to apply this kind of flagging within yarn / ember-cli. There are projects like `ember-try` which are designed for running against multiple version of a dependency, but they do not allow us to 'lock' dependency/sub-dependency versions, and are therefore unsuitable for our use in production.
Instead, we will be maintaining two root `package.json` files, and two `yarn.lock` files. For ember-3, they remain as-is. For ember5, we use a yarn 'resolution' to override the version for ember-source across the entire yarn workspace.
To allow for easy switching with minimal diff against the repository, `package.json` and `yarn.lock` are symlinks which point to `package-ember3.json` and `yarn-ember3.lock` by default. To switch to Ember 5, we can run `script/switch ember version 5` to update the symlinks to point to `package-ember5.json` and `package-ember3.json` respectively. In production, and when using `bin/ember-cli` for development, the ember version can also be upgraded using the `EMBER_VERSION=5` environment variable.
When making changes to dependencies, these should be made against the default `ember3` versions, and then `script/regen_ember_5_lockfile` should be used to regenerate `yarn-ember5.lock` accordingly. A new 'Ember Version Lockfiles' GitHub workflow will automate this process on Dependabot PRs.
When running a local environment against Ember 5, the two symlink changes will show up as git diffs. To avoid us accidentally committing/pushing that change, another GitHub workflow is introduced which checks the default Ember version and raises an error if it is greater than v3.
Supporting two ember versions simultaneously obviously carries significant overhead, so our aim will be to get themes/plugins updated as quickly as possible, and then drop this flag.
2023-11-27 10:52:17 -05:00
|
|
|
exception: true,
|
|
|
|
chdir: RAILS_ROOT,
|
|
|
|
)
|
|
|
|
|
2023-08-25 15:53:24 -04:00
|
|
|
# Running yarn install in the root directory will also run it for YARN_DIR via a post-install hook
|
|
|
|
exit 1 if !system "yarn", "-s", "install", "--cwd", RAILS_ROOT
|
2022-06-28 15:20:14 -04:00
|
|
|
|
|
|
|
yarn_env = {}
|
|
|
|
if ARGV.include?("--forward-host")
|
|
|
|
yarn_env["FORWARD_HOST"] = "true"
|
|
|
|
end
|
2021-06-08 22:44:33 -04:00
|
|
|
|
2021-06-09 09:48:43 -04:00
|
|
|
if ARGV.include?("-u") || ARGV.include?("--unicorn")
|
2021-06-09 10:32:28 -04:00
|
|
|
unicorn_env = { "DISCOURSE_PORT" => ENV["DISCOURSE_PORT"] || "4200" }
|
|
|
|
unicorn_pid = spawn(unicorn_env, __dir__ + "/unicorn")
|
2022-09-02 17:51:51 -04:00
|
|
|
ember_cli_pid = nil
|
2021-06-08 22:44:33 -04:00
|
|
|
|
|
|
|
Thread.new do
|
|
|
|
require 'open3'
|
2022-06-28 15:20:14 -04:00
|
|
|
Open3.popen2e(yarn_env, "yarn", *args.to_a.flatten) do |i, oe, t|
|
2022-09-02 17:51:51 -04:00
|
|
|
ember_cli_pid = t.pid
|
|
|
|
puts "Ember CLI running on PID: #{ember_cli_pid}"
|
2021-06-08 22:44:33 -04:00
|
|
|
oe.each do |line|
|
|
|
|
if line.include?("\e[32m200\e") || line.include?("\e[36m304\e[0m") || line.include?("POST /message-bus")
|
|
|
|
# skip 200s and 304s and message bus
|
|
|
|
else
|
|
|
|
puts line
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-09-02 17:51:51 -04:00
|
|
|
if process_running?(unicorn_pid)
|
|
|
|
puts "[bin/ember-cli] ember-cli process stopped. Terminating unicorn."
|
|
|
|
Process.kill("TERM", unicorn_pid)
|
|
|
|
end
|
2021-06-08 22:44:33 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
trap("SIGINT") do
|
|
|
|
# we got to swallow sigint to give time for
|
|
|
|
# children to handle it
|
|
|
|
end
|
|
|
|
|
|
|
|
Process.wait(unicorn_pid)
|
2022-09-02 17:51:51 -04:00
|
|
|
|
|
|
|
if ember_cli_pid && process_running?(ember_cli_pid)
|
|
|
|
puts "[bin/ember-cli] unicorn process stopped. Terminating ember-cli."
|
|
|
|
Process.kill("TERM", ember_cli_pid)
|
|
|
|
end
|
2021-06-08 22:44:33 -04:00
|
|
|
else
|
2022-06-28 15:20:14 -04:00
|
|
|
exec(yarn_env, "yarn", *args.to_a.flatten)
|
2021-06-08 22:44:33 -04:00
|
|
|
end
|