2019-05-02 18:17:27 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-01-30 17:10:36 -05:00
|
|
|
class GroupsController < ApplicationController
|
2018-01-31 23:17:59 -05:00
|
|
|
requires_login only: [
|
2016-11-29 03:25:02 -05:00
|
|
|
:set_notifications,
|
|
|
|
:mentionable,
|
2017-08-28 12:32:08 -04:00
|
|
|
:messageable,
|
2018-07-31 23:08:45 -04:00
|
|
|
:check_name,
|
2016-12-11 10:36:15 -05:00
|
|
|
:update,
|
2017-06-13 04:10:14 -04:00
|
|
|
:histories,
|
2017-07-21 02:12:24 -04:00
|
|
|
:request_membership,
|
2018-03-27 04:45:21 -04:00
|
|
|
:search,
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
:new,
|
|
|
|
:test_email_settings
|
2016-11-29 03:25:02 -05:00
|
|
|
]
|
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
skip_before_action :preload_json, :check_xhr, only: [:posts_feed, :mentions_feed]
|
2018-01-31 15:04:09 -05:00
|
|
|
skip_before_action :check_xhr, only: [:show]
|
2020-05-11 01:05:42 -04:00
|
|
|
after_action :add_noindex_header
|
2015-12-14 17:17:09 -05:00
|
|
|
|
2018-03-20 03:50:46 -04:00
|
|
|
TYPE_FILTERS = {
|
2018-03-21 04:32:08 -04:00
|
|
|
my: Proc.new { |groups, user|
|
|
|
|
raise Discourse::NotFound unless user
|
|
|
|
Group.member_of(groups, user)
|
2018-03-20 03:50:46 -04:00
|
|
|
},
|
2018-03-21 04:32:08 -04:00
|
|
|
owner: Proc.new { |groups, user|
|
|
|
|
raise Discourse::NotFound unless user
|
|
|
|
Group.owner_of(groups, user)
|
2018-03-20 03:50:46 -04:00
|
|
|
},
|
|
|
|
public: Proc.new { |groups|
|
|
|
|
groups.where(public_admission: true, automatic: false)
|
|
|
|
},
|
|
|
|
close: Proc.new { |groups|
|
2020-01-15 05:21:58 -05:00
|
|
|
groups.where(public_admission: false, automatic: false)
|
2018-03-20 03:50:46 -04:00
|
|
|
},
|
|
|
|
automatic: Proc.new { |groups|
|
|
|
|
groups.where(automatic: true)
|
2020-10-20 18:46:45 -04:00
|
|
|
},
|
|
|
|
non_automatic: Proc.new { |groups|
|
|
|
|
groups.where(automatic: false)
|
2018-03-20 03:50:46 -04:00
|
|
|
}
|
|
|
|
}
|
2020-08-24 18:55:21 -04:00
|
|
|
ADD_MEMBERS_LIMIT = 1000
|
2018-03-20 03:50:46 -04:00
|
|
|
|
2016-12-14 04:26:16 -05:00
|
|
|
def index
|
2018-04-09 21:22:01 -04:00
|
|
|
unless SiteSetting.enable_group_directory? || current_user&.staff?
|
2016-12-22 01:14:03 -05:00
|
|
|
raise Discourse::InvalidAccess.new(:enable_group_directory)
|
|
|
|
end
|
|
|
|
|
2018-03-19 04:14:50 -04:00
|
|
|
order = %w{name user_count}.delete(params[:order])
|
2020-01-15 05:21:58 -05:00
|
|
|
dir = params[:asc].to_s == "true" ? "ASC" : "DESC"
|
|
|
|
sort = order ? "#{order} #{dir}" : nil
|
|
|
|
groups = Group.visible_groups(current_user, sort)
|
2018-03-20 03:50:46 -04:00
|
|
|
type_filters = TYPE_FILTERS.keys
|
|
|
|
|
2020-01-15 05:21:58 -05:00
|
|
|
if (username = params[:username]).present?
|
|
|
|
raise Discourse::NotFound unless user = User.find_by_username(username)
|
|
|
|
groups = TYPE_FILTERS[:my].call(groups.members_visible_groups(current_user, sort), user)
|
2018-03-21 04:32:08 -04:00
|
|
|
type_filters = type_filters - [:my, :owner]
|
|
|
|
end
|
|
|
|
|
2020-01-15 05:21:58 -05:00
|
|
|
if (filter = params[:filter]).present?
|
|
|
|
groups = Group.search_groups(filter, groups: groups)
|
|
|
|
end
|
|
|
|
|
|
|
|
if !guardian.is_staff?
|
2017-07-03 15:26:46 -04:00
|
|
|
# hide automatic groups from all non stuff to de-clutter page
|
2018-03-21 04:32:08 -04:00
|
|
|
groups = groups.where("automatic IS FALSE OR groups.id = #{Group::AUTO_GROUPS[:moderators]}")
|
2018-03-20 03:50:46 -04:00
|
|
|
type_filters.delete(:automatic)
|
2017-07-03 15:26:46 -04:00
|
|
|
end
|
|
|
|
|
2017-08-08 09:45:27 -04:00
|
|
|
if Group.preloaded_custom_field_names.present?
|
|
|
|
Group.preload_custom_fields(groups, Group.preloaded_custom_field_names)
|
|
|
|
end
|
|
|
|
|
2018-03-20 03:50:46 -04:00
|
|
|
if type = params[:type]&.to_sym
|
2020-01-15 05:21:58 -05:00
|
|
|
raise Discourse::InvalidParameters.new(:type) unless callback = TYPE_FILTERS[type]
|
2018-06-28 20:43:33 -04:00
|
|
|
groups = callback.call(groups, current_user)
|
2018-03-20 03:50:46 -04:00
|
|
|
end
|
|
|
|
|
2018-03-19 06:28:57 -04:00
|
|
|
if current_user
|
|
|
|
group_users = GroupUser.where(group: groups, user: current_user)
|
|
|
|
user_group_ids = group_users.pluck(:group_id)
|
|
|
|
owner_group_ids = group_users.where(owner: true).pluck(:group_id)
|
2018-03-21 04:32:08 -04:00
|
|
|
else
|
|
|
|
type_filters = type_filters - [:my, :owner]
|
2018-03-19 06:28:57 -04:00
|
|
|
end
|
2016-12-21 07:58:51 -05:00
|
|
|
|
2020-10-20 18:46:45 -04:00
|
|
|
type_filters.delete(:non_automatic)
|
|
|
|
|
2020-01-16 17:57:34 -05:00
|
|
|
# count the total before doing pagination
|
|
|
|
total = groups.count
|
|
|
|
|
2020-01-15 05:21:58 -05:00
|
|
|
page = params[:page].to_i
|
|
|
|
page_size = MobileDetection.mobile_device?(request.user_agent) ? 15 : 36
|
2018-03-20 21:25:42 -04:00
|
|
|
groups = groups.offset(page * page_size).limit(page_size)
|
|
|
|
|
2016-12-21 07:58:51 -05:00
|
|
|
render_json_dump(
|
2018-03-19 06:28:57 -04:00
|
|
|
groups: serialize_data(groups,
|
|
|
|
BasicGroupSerializer,
|
|
|
|
user_group_ids: user_group_ids || [],
|
|
|
|
owner_group_ids: owner_group_ids || []
|
|
|
|
),
|
2018-03-20 03:50:46 -04:00
|
|
|
extras: {
|
2018-03-21 04:32:08 -04:00
|
|
|
type_filters: type_filters
|
2018-03-20 03:50:46 -04:00
|
|
|
},
|
2020-01-16 17:57:34 -05:00
|
|
|
total_rows_groups: total,
|
2018-08-20 05:08:50 -04:00
|
|
|
load_more_groups: groups_path(
|
|
|
|
page: page + 1,
|
|
|
|
type: type,
|
|
|
|
order: order,
|
|
|
|
asc: params[:asc],
|
|
|
|
filter: filter
|
2020-01-16 17:57:34 -05:00
|
|
|
)
|
2016-12-21 07:58:51 -05:00
|
|
|
)
|
2016-12-14 04:26:16 -05:00
|
|
|
end
|
|
|
|
|
2014-01-30 17:10:36 -05:00
|
|
|
def show
|
2018-01-31 15:04:09 -05:00
|
|
|
respond_to do |format|
|
|
|
|
group = find_group(:id)
|
|
|
|
|
|
|
|
format.html do
|
|
|
|
@title = group.full_name.present? ? group.full_name.capitalize : group.name
|
2021-07-12 10:35:57 -04:00
|
|
|
@full_title = "#{@title} - #{SiteSetting.title}"
|
2018-01-31 15:04:09 -05:00
|
|
|
@description_meta = group.bio_cooked.present? ? PrettyText.excerpt(group.bio_cooked, 300) : @title
|
|
|
|
render :show
|
|
|
|
end
|
|
|
|
|
|
|
|
format.json do
|
2018-03-29 02:57:10 -04:00
|
|
|
groups = Group.visible_groups(current_user)
|
2020-09-10 14:36:40 -04:00
|
|
|
if !guardian.is_staff?
|
|
|
|
groups = groups.where("automatic IS FALSE OR groups.id = #{Group::AUTO_GROUPS[:moderators]}")
|
|
|
|
end
|
2018-03-29 02:57:10 -04:00
|
|
|
|
|
|
|
render_json_dump(
|
|
|
|
group: serialize_data(group, GroupShowSerializer, root: nil),
|
|
|
|
extras: {
|
|
|
|
visible_group_names: groups.pluck(:name)
|
|
|
|
}
|
|
|
|
)
|
2018-01-31 15:04:09 -05:00
|
|
|
end
|
|
|
|
end
|
2014-01-30 17:10:36 -05:00
|
|
|
end
|
|
|
|
|
2018-03-27 04:45:21 -04:00
|
|
|
def new
|
|
|
|
end
|
|
|
|
|
2016-12-13 02:15:20 -05:00
|
|
|
def edit
|
|
|
|
end
|
|
|
|
|
2016-11-29 03:25:02 -05:00
|
|
|
def update
|
|
|
|
group = Group.find(params[:id])
|
2020-08-19 10:41:40 -04:00
|
|
|
guardian.ensure_can_edit!(group) unless guardian.can_admin_group?(group)
|
2016-11-29 03:25:02 -05:00
|
|
|
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
params_with_permitted = group_params(automatic: group.automatic)
|
|
|
|
clear_disabled_email_settings(group, params_with_permitted)
|
|
|
|
|
2021-07-15 10:23:57 -04:00
|
|
|
categories, tags = []
|
|
|
|
if !group.automatic || current_user.admin
|
2021-08-31 06:41:26 -04:00
|
|
|
notification_level, categories, tags = user_default_notifications(group, params_with_permitted)
|
2021-07-15 10:23:57 -04:00
|
|
|
|
|
|
|
if params[:update_existing_users].blank?
|
2021-08-31 06:41:26 -04:00
|
|
|
user_count = count_existing_users(group.group_users, notification_level, categories, tags)
|
2021-07-15 10:23:57 -04:00
|
|
|
|
|
|
|
if user_count > 0
|
|
|
|
render json: { user_count: user_count }
|
|
|
|
return
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
if group.update(params_with_permitted)
|
2021-07-28 07:04:04 -04:00
|
|
|
GroupActionLogger.new(current_user, group).log_change_group_settings
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
group.record_email_setting_changes!(current_user)
|
|
|
|
group.expire_imap_mailbox_cache
|
2021-08-31 06:41:26 -04:00
|
|
|
update_existing_users(group.group_users, notification_level, categories, tags) if params[:update_existing_users] == "true"
|
2022-01-03 19:14:33 -05:00
|
|
|
AdminDashboardData.clear_found_problem("group_#{group.id}_email_credentials")
|
2020-08-19 10:41:40 -04:00
|
|
|
|
|
|
|
if guardian.can_see?(group)
|
|
|
|
render json: success_json
|
|
|
|
else
|
|
|
|
# They can no longer see the group after changing permissions
|
|
|
|
render json: { route_to: '/g' }
|
|
|
|
end
|
2016-11-29 03:25:02 -05:00
|
|
|
else
|
|
|
|
render_json_error(group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-02-07 10:44:03 -05:00
|
|
|
def posts
|
2014-02-18 16:43:02 -05:00
|
|
|
group = find_group(:group_id)
|
2019-08-14 09:30:04 -04:00
|
|
|
guardian.ensure_can_see_group_members!(group)
|
|
|
|
|
2017-10-31 16:47:47 -04:00
|
|
|
posts = group.posts_for(
|
|
|
|
guardian,
|
|
|
|
params.permit(:before_post_id, :category_id)
|
|
|
|
).limit(20)
|
2014-02-07 10:44:03 -05:00
|
|
|
render_serialized posts.to_a, GroupPostSerializer
|
|
|
|
end
|
|
|
|
|
2016-03-18 12:19:45 -04:00
|
|
|
def posts_feed
|
|
|
|
group = find_group(:group_id)
|
2019-08-14 09:30:04 -04:00
|
|
|
guardian.ensure_can_see_group_members!(group)
|
|
|
|
|
2017-10-31 16:47:47 -04:00
|
|
|
@posts = group.posts_for(
|
|
|
|
guardian,
|
|
|
|
params.permit(:before_post_id, :category_id)
|
|
|
|
).limit(50)
|
2016-03-18 12:19:45 -04:00
|
|
|
@title = "#{SiteSetting.title} - #{I18n.t("rss_description.group_posts", group_name: group.name)}"
|
|
|
|
@link = Discourse.base_url
|
|
|
|
@description = I18n.t("rss_description.group_posts", group_name: group.name)
|
|
|
|
render 'posts/latest', formats: [:rss]
|
|
|
|
end
|
|
|
|
|
2015-12-01 00:52:43 -05:00
|
|
|
def mentions
|
2017-12-07 16:16:53 -05:00
|
|
|
raise Discourse::NotFound unless SiteSetting.enable_mentions?
|
2015-12-01 00:52:43 -05:00
|
|
|
group = find_group(:group_id)
|
2017-10-31 16:47:47 -04:00
|
|
|
posts = group.mentioned_posts_for(
|
|
|
|
guardian,
|
|
|
|
params.permit(:before_post_id, :category_id)
|
|
|
|
).limit(20)
|
2015-12-01 00:52:43 -05:00
|
|
|
render_serialized posts.to_a, GroupPostSerializer
|
|
|
|
end
|
|
|
|
|
2016-03-18 12:19:45 -04:00
|
|
|
def mentions_feed
|
2017-12-07 16:16:53 -05:00
|
|
|
raise Discourse::NotFound unless SiteSetting.enable_mentions?
|
2016-03-18 12:19:45 -04:00
|
|
|
group = find_group(:group_id)
|
2017-10-31 16:47:47 -04:00
|
|
|
@posts = group.mentioned_posts_for(
|
|
|
|
guardian,
|
|
|
|
params.permit(:before_post_id, :category_id)
|
|
|
|
).limit(50)
|
2016-03-18 12:19:45 -04:00
|
|
|
@title = "#{SiteSetting.title} - #{I18n.t("rss_description.group_mentions", group_name: group.name)}"
|
|
|
|
@link = Discourse.base_url
|
|
|
|
@description = I18n.t("rss_description.group_mentions", group_name: group.name)
|
|
|
|
render 'posts/latest', formats: [:rss]
|
|
|
|
end
|
|
|
|
|
2014-02-06 13:06:19 -05:00
|
|
|
def members
|
2014-02-18 16:43:02 -05:00
|
|
|
group = find_group(:group_id)
|
2014-11-24 15:12:48 -05:00
|
|
|
|
2019-08-14 09:30:04 -04:00
|
|
|
guardian.ensure_can_see_group_members!(group)
|
|
|
|
|
2019-11-18 07:59:28 -05:00
|
|
|
limit = (params[:limit] || 50).to_i
|
2015-01-05 12:51:45 -05:00
|
|
|
offset = params[:offset].to_i
|
2018-06-28 20:14:50 -04:00
|
|
|
|
2019-11-18 07:59:28 -05:00
|
|
|
raise Discourse::InvalidParameters.new(:limit) if limit < 0 || limit > 1000
|
|
|
|
raise Discourse::InvalidParameters.new(:offset) if offset < 0
|
2018-06-28 20:14:50 -04:00
|
|
|
|
2020-05-14 22:10:59 -04:00
|
|
|
dir = (params[:asc] && params[:asc].present?) ? 'ASC' : 'DESC'
|
|
|
|
if params[:desc]
|
2021-11-12 09:52:59 -05:00
|
|
|
Discourse.deprecate(":desc is deprecated please use :asc instead", output_in_test: true, drop_from: '2.9.0')
|
2020-05-14 22:10:59 -04:00
|
|
|
dir = (params[:desc] && params[:desc].present?) ? 'DESC' : 'ASC'
|
|
|
|
end
|
2016-12-22 01:55:24 -05:00
|
|
|
order = ""
|
2016-12-07 04:28:43 -05:00
|
|
|
|
2019-03-27 07:30:59 -04:00
|
|
|
if params[:requesters]
|
|
|
|
guardian.ensure_can_edit!(group)
|
|
|
|
|
|
|
|
users = group.requesters
|
|
|
|
total = users.count
|
|
|
|
|
|
|
|
if (filter = params[:filter]).present?
|
|
|
|
filter = filter.split(',') if filter.include?(',')
|
|
|
|
|
|
|
|
if current_user&.admin
|
|
|
|
users = users.filter_by_username_or_email(filter)
|
|
|
|
else
|
|
|
|
users = users.filter_by_username(filter)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
users = users
|
|
|
|
.select("users.*, group_requests.reason, group_requests.created_at requested_at")
|
|
|
|
.order(params[:order] == 'requested_at' ? "group_requests.created_at #{dir}" : "")
|
|
|
|
.order(username_lower: dir)
|
|
|
|
.limit(limit)
|
|
|
|
.offset(offset)
|
|
|
|
|
|
|
|
return render json: {
|
|
|
|
members: serialize_data(users, GroupRequesterSerializer),
|
|
|
|
meta: {
|
|
|
|
total: total,
|
|
|
|
limit: limit,
|
|
|
|
offset: offset
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2016-12-07 04:28:43 -05:00
|
|
|
if params[:order] && %w{last_posted_at last_seen_at}.include?(params[:order])
|
2016-12-22 01:55:24 -05:00
|
|
|
order = "#{params[:order]} #{dir} NULLS LAST"
|
2018-11-01 00:33:28 -04:00
|
|
|
elsif params[:order] == 'added_at'
|
|
|
|
order = "group_users.created_at #{dir}"
|
2016-12-07 04:28:43 -05:00
|
|
|
end
|
|
|
|
|
2017-10-05 22:35:40 -04:00
|
|
|
users = group.users.human_users
|
|
|
|
total = users.count
|
2018-03-22 01:42:46 -04:00
|
|
|
|
2018-03-26 02:30:37 -04:00
|
|
|
if (filter = params[:filter]).present?
|
|
|
|
filter = filter.split(',') if filter.include?(',')
|
|
|
|
|
|
|
|
if current_user&.admin
|
|
|
|
users = users.filter_by_username_or_email(filter)
|
|
|
|
else
|
|
|
|
users = users.filter_by_username(filter)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-11-24 19:49:27 -05:00
|
|
|
users = users.joins(:user_option).select('users.*, user_options.timezone, group_users.created_at as added_at')
|
2018-11-01 00:33:28 -04:00
|
|
|
|
2017-10-05 22:35:40 -04:00
|
|
|
members = users
|
2016-12-07 04:28:43 -05:00
|
|
|
.order('NOT group_users.owner')
|
|
|
|
.order(order)
|
2016-12-08 01:26:50 -05:00
|
|
|
.order(username_lower: dir)
|
2016-12-07 04:28:43 -05:00
|
|
|
.limit(limit)
|
|
|
|
.offset(offset)
|
2018-12-06 06:18:52 -05:00
|
|
|
.includes(:primary_group)
|
2016-12-07 04:28:43 -05:00
|
|
|
|
2017-10-05 22:35:40 -04:00
|
|
|
owners = users
|
2016-12-07 04:28:43 -05:00
|
|
|
.order(order)
|
2016-12-08 01:26:50 -05:00
|
|
|
.order(username_lower: dir)
|
2016-12-07 04:28:43 -05:00
|
|
|
.where('group_users.owner')
|
2018-12-06 06:18:52 -05:00
|
|
|
.includes(:primary_group)
|
2015-01-05 12:51:45 -05:00
|
|
|
|
|
|
|
render json: {
|
|
|
|
members: serialize_data(members, GroupUserSerializer),
|
2015-11-09 08:52:04 -05:00
|
|
|
owners: serialize_data(owners, GroupUserSerializer),
|
2015-01-05 12:51:45 -05:00
|
|
|
meta: {
|
|
|
|
total: total,
|
|
|
|
limit: limit,
|
|
|
|
offset: offset
|
|
|
|
}
|
|
|
|
}
|
2014-02-06 13:06:19 -05:00
|
|
|
end
|
|
|
|
|
2015-01-08 18:35:52 -05:00
|
|
|
def add_members
|
2015-11-09 08:52:04 -05:00
|
|
|
group = Group.find(params[:id])
|
2021-07-22 03:11:23 -04:00
|
|
|
guardian.ensure_can_edit!(group)
|
2015-11-09 08:52:04 -05:00
|
|
|
|
2021-07-22 03:11:23 -04:00
|
|
|
users = users_from_params.to_a
|
2020-08-04 11:02:01 -04:00
|
|
|
emails = []
|
|
|
|
if params[:emails]
|
|
|
|
params[:emails].split(",").each do |email|
|
|
|
|
existing_user = User.find_by_email(email)
|
|
|
|
existing_user.present? ? users.push(existing_user) : emails.push(email)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-06-02 09:28:21 -04:00
|
|
|
guardian.ensure_can_invite_to_forum!([group]) if emails.present?
|
|
|
|
|
2020-08-04 11:02:01 -04:00
|
|
|
if users.empty? && emails.empty?
|
2021-02-08 11:57:59 -05:00
|
|
|
raise Discourse::InvalidParameters.new(I18n.t("groups.errors.usernames_or_emails_required"))
|
2021-02-03 12:13:00 -05:00
|
|
|
end
|
|
|
|
|
2020-08-24 18:55:21 -04:00
|
|
|
if users.length > ADD_MEMBERS_LIMIT
|
|
|
|
return render_json_error(
|
2021-02-02 04:50:04 -05:00
|
|
|
I18n.t("groups.errors.adding_too_many_users", count: ADD_MEMBERS_LIMIT)
|
2020-08-24 18:55:21 -04:00
|
|
|
)
|
|
|
|
end
|
2021-02-03 12:13:00 -05:00
|
|
|
|
2020-08-20 23:38:09 -04:00
|
|
|
usernames_already_in_group = group.users.where(id: users.map(&:id)).pluck(:username)
|
2021-02-04 05:06:08 -05:00
|
|
|
if usernames_already_in_group.present? &&
|
|
|
|
usernames_already_in_group.length == users.length &&
|
|
|
|
emails.blank?
|
2018-03-26 02:30:37 -04:00
|
|
|
render_json_error(I18n.t(
|
|
|
|
"groups.errors.member_already_exist",
|
2020-08-20 23:38:09 -04:00
|
|
|
username: usernames_already_in_group.sort.join(", "),
|
|
|
|
count: usernames_already_in_group.size
|
2018-03-26 02:30:37 -04:00
|
|
|
))
|
|
|
|
else
|
2021-07-22 03:11:23 -04:00
|
|
|
notify = params[:notify_users]&.to_s == "true"
|
2020-08-04 11:02:01 -04:00
|
|
|
uniq_users = users.uniq
|
|
|
|
uniq_users.each do |user|
|
2021-07-22 03:11:23 -04:00
|
|
|
add_user_to_group(group, user, notify)
|
2015-01-08 18:35:52 -05:00
|
|
|
end
|
|
|
|
|
2020-08-04 11:02:01 -04:00
|
|
|
emails.each do |email|
|
2021-05-21 04:34:17 -04:00
|
|
|
begin
|
|
|
|
Invite.generate(current_user, email: email, group_ids: [group.id])
|
|
|
|
rescue RateLimiter::LimitExceeded => e
|
|
|
|
return render_json_error(I18n.t(
|
|
|
|
"invite.rate_limit",
|
|
|
|
count: SiteSetting.max_invites_per_day,
|
|
|
|
time_left: e.time_left
|
|
|
|
))
|
|
|
|
end
|
2020-08-04 11:02:01 -04:00
|
|
|
end
|
|
|
|
|
2018-03-26 02:30:37 -04:00
|
|
|
render json: success_json.merge!(
|
2020-08-04 11:02:01 -04:00
|
|
|
usernames: uniq_users.map(&:username),
|
|
|
|
emails: emails
|
2018-03-26 02:30:37 -04:00
|
|
|
)
|
2015-11-09 08:52:04 -05:00
|
|
|
end
|
2015-01-08 18:35:52 -05:00
|
|
|
end
|
|
|
|
|
2021-07-22 03:11:23 -04:00
|
|
|
def join
|
|
|
|
ensure_logged_in
|
|
|
|
unless current_user.staff?
|
|
|
|
RateLimiter.new(current_user, "public_group_membership", 3, 1.minute).performed!
|
|
|
|
end
|
|
|
|
|
|
|
|
group = Group.find(params[:id])
|
2021-07-22 10:48:26 -04:00
|
|
|
raise Discourse::NotFound unless group
|
2021-07-22 03:11:23 -04:00
|
|
|
raise Discourse::InvalidAccess unless group.public_admission
|
|
|
|
|
|
|
|
return if group.users.exists?(id: current_user.id)
|
|
|
|
add_user_to_group(group, current_user)
|
|
|
|
end
|
|
|
|
|
2019-03-27 07:30:59 -04:00
|
|
|
def handle_membership_request
|
|
|
|
group = Group.find_by(id: params[:id])
|
|
|
|
raise Discourse::InvalidParameters.new(:id) if group.blank?
|
|
|
|
guardian.ensure_can_edit!(group)
|
|
|
|
|
2020-05-26 09:28:03 -04:00
|
|
|
user = User.find_by(id: params[:user_id])
|
|
|
|
raise Discourse::InvalidParameters.new(:user_id) if user.blank?
|
2019-03-27 07:30:59 -04:00
|
|
|
|
2020-05-26 09:28:03 -04:00
|
|
|
ActiveRecord::Base.transaction do
|
2019-03-27 07:30:59 -04:00
|
|
|
if params[:accept]
|
2020-05-26 09:28:03 -04:00
|
|
|
group.add(user)
|
2019-03-27 07:30:59 -04:00
|
|
|
GroupActionLogger.new(current_user, group).log_add_user_to_group(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
GroupRequest.where(group_id: group.id, user_id: user.id).delete_all
|
|
|
|
end
|
|
|
|
|
2020-05-26 09:28:03 -04:00
|
|
|
if params[:accept]
|
|
|
|
PostCreator.new(current_user,
|
|
|
|
title: I18n.t('groups.request_accepted_pm.title', group_name: group.name),
|
|
|
|
raw: I18n.t('groups.request_accepted_pm.body', group_name: group.name),
|
|
|
|
archetype: Archetype.private_message,
|
|
|
|
target_usernames: user.username,
|
|
|
|
skip_validations: true
|
|
|
|
).create!
|
|
|
|
end
|
|
|
|
|
2019-03-27 07:30:59 -04:00
|
|
|
render json: success_json
|
|
|
|
end
|
|
|
|
|
2016-11-25 03:45:15 -05:00
|
|
|
def mentionable
|
2018-06-05 21:42:09 -04:00
|
|
|
group = find_group(:group_id, ensure_can_see: false)
|
2016-11-25 03:45:15 -05:00
|
|
|
|
|
|
|
if group
|
|
|
|
render json: { mentionable: Group.mentionable(current_user).where(id: group.id).present? }
|
|
|
|
else
|
|
|
|
raise Discourse::InvalidAccess.new
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-28 12:32:08 -04:00
|
|
|
def messageable
|
2018-06-05 21:42:09 -04:00
|
|
|
group = find_group(:group_id, ensure_can_see: false)
|
2017-08-28 12:32:08 -04:00
|
|
|
|
|
|
|
if group
|
2021-08-30 01:08:33 -04:00
|
|
|
render json: { messageable: guardian.can_send_private_message?(group) }
|
2017-08-28 12:32:08 -04:00
|
|
|
else
|
|
|
|
raise Discourse::InvalidAccess.new
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-07-31 23:08:45 -04:00
|
|
|
def check_name
|
|
|
|
group_name = params.require(:group_name)
|
|
|
|
checker = UsernameCheckerService.new(allow_reserved_username: true)
|
|
|
|
render json: checker.check_username(group_name, nil)
|
|
|
|
end
|
|
|
|
|
2015-01-08 18:35:52 -05:00
|
|
|
def remove_member
|
2018-04-06 05:11:00 -04:00
|
|
|
group = Group.find_by(id: params[:id])
|
|
|
|
raise Discourse::NotFound unless group
|
2021-07-22 12:14:18 -04:00
|
|
|
guardian.ensure_can_edit!(group)
|
2016-12-06 23:06:56 -05:00
|
|
|
|
2018-10-11 17:27:41 -04:00
|
|
|
# Maintain backwards compatibility
|
|
|
|
params[:usernames] = params[:username] if params[:username].present?
|
|
|
|
params[:user_emails] = params[:user_email] if params[:user_email].present?
|
2015-11-09 08:52:04 -05:00
|
|
|
|
2018-10-11 17:27:41 -04:00
|
|
|
users = users_from_params
|
2020-08-04 11:02:01 -04:00
|
|
|
raise Discourse::InvalidParameters.new(
|
|
|
|
'user_ids or usernames or user_emails must be present'
|
|
|
|
) if users.empty?
|
2016-12-06 23:06:56 -05:00
|
|
|
|
2020-07-22 16:27:43 -04:00
|
|
|
removed_users = []
|
|
|
|
skipped_users = []
|
|
|
|
|
2018-10-11 17:27:41 -04:00
|
|
|
users.each do |user|
|
2020-03-10 17:25:00 -04:00
|
|
|
if group.remove(user)
|
2020-07-22 16:27:43 -04:00
|
|
|
removed_users << user.username
|
2020-03-10 17:25:00 -04:00
|
|
|
GroupActionLogger.new(current_user, group).log_remove_user_from_group(user)
|
|
|
|
else
|
2020-07-22 16:27:43 -04:00
|
|
|
if group.users.exclude? user
|
|
|
|
skipped_users << user.username
|
|
|
|
else
|
|
|
|
raise Discourse::InvalidParameters
|
|
|
|
end
|
2020-03-10 17:25:00 -04:00
|
|
|
end
|
2015-01-08 18:35:52 -05:00
|
|
|
end
|
2018-10-11 17:27:41 -04:00
|
|
|
|
|
|
|
render json: success_json.merge!(
|
2020-07-22 16:27:43 -04:00
|
|
|
usernames: removed_users,
|
|
|
|
skipped_usernames: skipped_users
|
2018-10-11 17:27:41 -04:00
|
|
|
)
|
2017-06-13 04:10:14 -04:00
|
|
|
end
|
|
|
|
|
2021-07-22 12:14:18 -04:00
|
|
|
def leave
|
|
|
|
ensure_logged_in
|
|
|
|
unless current_user.staff?
|
|
|
|
RateLimiter.new(current_user, "public_group_membership", 3, 1.minute).performed!
|
|
|
|
end
|
|
|
|
|
|
|
|
group = Group.find_by(id: params[:id])
|
|
|
|
raise Discourse::NotFound unless group
|
|
|
|
raise Discourse::InvalidAccess unless group.public_exit
|
|
|
|
|
|
|
|
if group.remove(current_user)
|
|
|
|
GroupActionLogger.new(current_user, group).log_remove_user_from_group(current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-05-20 01:28:36 -04:00
|
|
|
MAX_NOTIFIED_OWNERS ||= 20
|
|
|
|
|
2017-06-13 04:10:14 -04:00
|
|
|
def request_membership
|
2020-08-24 19:29:18 -04:00
|
|
|
params.require(:reason)
|
2017-08-08 05:53:02 -04:00
|
|
|
|
2017-06-13 04:10:14 -04:00
|
|
|
group = find_group(:id)
|
2019-04-22 22:51:30 -04:00
|
|
|
|
|
|
|
begin
|
2020-08-24 19:29:18 -04:00
|
|
|
GroupRequest.create!(group: group, user: current_user, reason: params[:reason])
|
2021-05-20 01:28:36 -04:00
|
|
|
rescue ActiveRecord::RecordNotUnique
|
2019-04-22 22:51:30 -04:00
|
|
|
return render json: failed_json.merge(error: I18n.t("groups.errors.already_requested_membership")), status: 409
|
|
|
|
end
|
2017-06-14 23:36:09 -04:00
|
|
|
|
|
|
|
usernames = [current_user.username].concat(
|
|
|
|
group.users.where('group_users.owner')
|
|
|
|
.order("users.last_seen_at DESC")
|
2021-05-20 01:28:36 -04:00
|
|
|
.limit(MAX_NOTIFIED_OWNERS)
|
2017-06-14 23:36:09 -04:00
|
|
|
.pluck("users.username")
|
|
|
|
)
|
2017-06-13 04:10:14 -04:00
|
|
|
|
|
|
|
post = PostCreator.new(current_user,
|
2019-04-22 22:51:30 -04:00
|
|
|
title: I18n.t('groups.request_membership_pm.title', group_name: group.name),
|
2019-08-06 06:28:22 -04:00
|
|
|
raw: params[:reason],
|
2017-06-13 04:10:14 -04:00
|
|
|
archetype: Archetype.private_message,
|
2017-06-14 23:36:09 -04:00
|
|
|
target_usernames: usernames.join(','),
|
2020-03-24 05:12:52 -04:00
|
|
|
topic_opts: { custom_fields: { requested_group_id: group.id } },
|
2017-06-13 04:10:14 -04:00
|
|
|
skip_validations: true
|
|
|
|
).create!
|
|
|
|
|
|
|
|
render json: success_json.merge(relative_url: post.topic.relative_url)
|
2015-01-08 18:35:52 -05:00
|
|
|
end
|
|
|
|
|
2015-12-14 17:17:09 -05:00
|
|
|
def set_notifications
|
|
|
|
group = find_group(:id)
|
|
|
|
notification_level = params.require(:notification_level)
|
|
|
|
|
2017-04-20 15:47:25 -04:00
|
|
|
user_id = current_user.id
|
|
|
|
if guardian.is_staff?
|
|
|
|
user_id = params[:user_id] || user_id
|
|
|
|
end
|
|
|
|
|
2015-12-14 17:17:09 -05:00
|
|
|
GroupUser.where(group_id: group.id)
|
2017-04-20 15:47:25 -04:00
|
|
|
.where(user_id: user_id)
|
2015-12-14 17:17:09 -05:00
|
|
|
.update_all(notification_level: notification_level)
|
|
|
|
|
|
|
|
render json: success_json
|
|
|
|
end
|
|
|
|
|
2016-12-11 10:36:15 -05:00
|
|
|
def histories
|
|
|
|
group = find_group(:group_id)
|
2020-08-19 10:41:40 -04:00
|
|
|
guardian.ensure_can_edit!(group) unless guardian.can_admin_group?(group)
|
2016-12-11 10:36:15 -05:00
|
|
|
|
|
|
|
page_size = 25
|
|
|
|
offset = (params[:offset] && params[:offset].to_i) || 0
|
|
|
|
|
|
|
|
group_histories = GroupHistory.with_filters(group, params[:filters])
|
|
|
|
.limit(page_size)
|
|
|
|
.offset(offset * page_size)
|
|
|
|
|
|
|
|
render_json_dump(
|
|
|
|
logs: serialize_data(group_histories, BasicGroupHistorySerializer),
|
|
|
|
all_loaded: group_histories.count < page_size
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2017-07-21 02:12:24 -04:00
|
|
|
def search
|
|
|
|
groups = Group.visible_groups(current_user)
|
|
|
|
.where("groups.id <> ?", Group::AUTO_GROUPS[:everyone])
|
2020-10-05 04:22:55 -04:00
|
|
|
.includes(:flair_upload)
|
2017-07-21 02:12:24 -04:00
|
|
|
.order(:name)
|
|
|
|
|
2020-01-15 05:21:58 -05:00
|
|
|
if (term = params[:term]).present?
|
2017-07-21 02:12:24 -04:00
|
|
|
groups = groups.where("name ILIKE :term OR full_name ILIKE :term", term: "%#{term}%")
|
|
|
|
end
|
|
|
|
|
|
|
|
if params[:ignore_automatic].to_s == "true"
|
|
|
|
groups = groups.where(automatic: false)
|
|
|
|
end
|
|
|
|
|
2017-08-08 09:45:27 -04:00
|
|
|
if Group.preloaded_custom_field_names.present?
|
|
|
|
Group.preload_custom_fields(groups, Group.preloaded_custom_field_names)
|
|
|
|
end
|
|
|
|
|
2017-07-21 02:12:24 -04:00
|
|
|
render_serialized(groups, BasicGroupSerializer)
|
|
|
|
end
|
|
|
|
|
2020-08-10 10:49:05 -04:00
|
|
|
def permissions
|
|
|
|
group = find_group(:id)
|
|
|
|
category_groups = group.category_groups.select { |category_group| guardian.can_see_category?(category_group.category) }
|
|
|
|
render_serialized(category_groups.sort_by { |category_group| category_group.category.name }, CategoryGroupSerializer)
|
|
|
|
end
|
|
|
|
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
def test_email_settings
|
|
|
|
params.require(:group_id)
|
|
|
|
params.require(:protocol)
|
|
|
|
params.require(:port)
|
|
|
|
params.require(:host)
|
|
|
|
params.require(:username)
|
|
|
|
params.require(:password)
|
|
|
|
params.require(:ssl)
|
|
|
|
|
|
|
|
group = Group.find(params[:group_id])
|
|
|
|
guardian.ensure_can_edit!(group)
|
|
|
|
|
|
|
|
RateLimiter.new(current_user, "group_test_email_settings", 5, 1.minute).performed!
|
|
|
|
|
|
|
|
settings = params.except(:group_id, :protocol)
|
|
|
|
enable_tls = settings[:ssl] == "true"
|
|
|
|
email_host = params[:host]
|
|
|
|
|
|
|
|
if !["smtp", "imap"].include?(params[:protocol])
|
|
|
|
raise Discourse::InvalidParameters.new("Valid protocols to test are smtp and imap")
|
|
|
|
end
|
|
|
|
|
|
|
|
hijack do
|
|
|
|
begin
|
|
|
|
case params[:protocol]
|
|
|
|
when "smtp"
|
|
|
|
enable_starttls_auto = false
|
|
|
|
settings.delete(:ssl)
|
|
|
|
|
|
|
|
final_settings = settings.merge(enable_tls: enable_tls, enable_starttls_auto: enable_starttls_auto)
|
|
|
|
.permit(:host, :port, :username, :password, :enable_tls, :enable_starttls_auto, :debug)
|
|
|
|
EmailSettingsValidator.validate_as_user(current_user, "smtp", **final_settings.to_h.symbolize_keys)
|
|
|
|
when "imap"
|
|
|
|
final_settings = settings.merge(ssl: enable_tls)
|
|
|
|
.permit(:host, :port, :username, :password, :ssl, :debug)
|
|
|
|
EmailSettingsValidator.validate_as_user(current_user, "imap", **final_settings.to_h.symbolize_keys)
|
|
|
|
end
|
|
|
|
rescue *EmailSettingsExceptionHandler::EXPECTED_EXCEPTIONS, StandardError => err
|
|
|
|
return render_json_error(
|
|
|
|
EmailSettingsExceptionHandler.friendly_exception_message(err, email_host)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
render json: success_json
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-02-18 16:43:02 -05:00
|
|
|
private
|
|
|
|
|
2021-07-22 03:11:23 -04:00
|
|
|
def add_user_to_group(group, user, notify = false)
|
|
|
|
group.add(user)
|
|
|
|
GroupActionLogger.new(current_user, group).log_add_user_to_group(user)
|
|
|
|
group.notify_added_to_group(user) if notify
|
|
|
|
rescue ActiveRecord::RecordNotUnique
|
|
|
|
# Under concurrency, we might attempt to insert two records quickly and hit a DB
|
|
|
|
# constraint. In this case we can safely ignore the error and act as if the user
|
|
|
|
# was added to the group.
|
|
|
|
end
|
|
|
|
|
2018-04-05 01:53:00 -04:00
|
|
|
def group_params(automatic: false)
|
|
|
|
permitted_params =
|
|
|
|
if automatic
|
|
|
|
%i{
|
|
|
|
visibility_level
|
|
|
|
mentionable_level
|
|
|
|
messageable_level
|
|
|
|
default_notification_level
|
2019-04-17 22:44:30 -04:00
|
|
|
bio_raw
|
2021-04-06 11:13:06 -04:00
|
|
|
flair_icon
|
|
|
|
flair_upload_id
|
|
|
|
flair_bg_color
|
|
|
|
flair_color
|
2018-04-05 01:53:00 -04:00
|
|
|
}
|
|
|
|
else
|
|
|
|
default_params = %i{
|
|
|
|
mentionable_level
|
|
|
|
messageable_level
|
|
|
|
title
|
2020-05-25 01:38:47 -04:00
|
|
|
flair_icon
|
|
|
|
flair_upload_id
|
2018-04-05 01:53:00 -04:00
|
|
|
flair_bg_color
|
|
|
|
flair_color
|
|
|
|
bio_raw
|
|
|
|
public_admission
|
|
|
|
public_exit
|
|
|
|
allow_membership_requests
|
|
|
|
full_name
|
|
|
|
default_notification_level
|
|
|
|
membership_request_template
|
|
|
|
}
|
|
|
|
|
2020-08-19 10:41:40 -04:00
|
|
|
if current_user.staff?
|
2018-04-05 23:44:58 -04:00
|
|
|
default_params.push(*[
|
|
|
|
:incoming_email,
|
2020-07-10 05:05:55 -04:00
|
|
|
:smtp_server,
|
|
|
|
:smtp_port,
|
|
|
|
:smtp_ssl,
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
:smtp_enabled,
|
|
|
|
:smtp_updated_by,
|
|
|
|
:smtp_updated_at,
|
2020-07-10 05:05:55 -04:00
|
|
|
:imap_server,
|
|
|
|
:imap_port,
|
|
|
|
:imap_ssl,
|
|
|
|
:imap_mailbox_name,
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
:imap_enabled,
|
|
|
|
:imap_updated_by,
|
|
|
|
:imap_updated_at,
|
2020-07-10 05:05:55 -04:00
|
|
|
:email_username,
|
|
|
|
:email_password,
|
2022-02-06 22:52:01 -05:00
|
|
|
:email_from_alias,
|
2018-04-05 23:44:58 -04:00
|
|
|
:primary_group,
|
|
|
|
:visibility_level,
|
2019-08-14 09:30:04 -04:00
|
|
|
:members_visibility_level,
|
2018-04-05 23:44:58 -04:00
|
|
|
:name,
|
|
|
|
:grant_trust_level,
|
|
|
|
:automatic_membership_email_domains,
|
2021-01-28 18:59:10 -05:00
|
|
|
:publish_read_state,
|
|
|
|
:allow_unknown_sender_topic_replies
|
2018-04-05 23:44:58 -04:00
|
|
|
])
|
2019-06-05 22:05:33 -04:00
|
|
|
|
2020-05-15 09:04:38 -04:00
|
|
|
custom_fields = DiscoursePluginRegistry.editable_group_custom_fields
|
2019-06-05 22:05:33 -04:00
|
|
|
default_params << { custom_fields: custom_fields } unless custom_fields.blank?
|
2018-04-05 01:53:00 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
default_params
|
|
|
|
end
|
2018-03-27 00:18:03 -04:00
|
|
|
|
2020-08-06 12:27:27 -04:00
|
|
|
if !automatic || current_user.admin
|
2020-08-13 17:20:23 -04:00
|
|
|
[:muted, :regular, :tracking, :watching, :watching_first_post].each do |level|
|
2020-08-06 12:27:27 -04:00
|
|
|
permitted_params << { "#{level}_category_ids" => [] }
|
|
|
|
permitted_params << { "#{level}_tags" => [] }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-12-09 07:30:27 -05:00
|
|
|
if guardian.can_associate_groups?
|
|
|
|
permitted_params << { associated_group_ids: [] }
|
|
|
|
end
|
|
|
|
|
2021-09-05 20:18:51 -04:00
|
|
|
permitted_params = permitted_params | DiscoursePluginRegistry.group_params
|
|
|
|
|
2018-03-27 00:18:03 -04:00
|
|
|
params.require(:group).permit(*permitted_params)
|
2016-11-29 03:25:02 -05:00
|
|
|
end
|
|
|
|
|
2018-06-05 06:56:51 -04:00
|
|
|
def find_group(param_name, ensure_can_see: true)
|
2016-11-29 03:25:02 -05:00
|
|
|
name = params.require(param_name)
|
2020-01-15 05:21:58 -05:00
|
|
|
group = Group.find_by("LOWER(name) = ?", name.downcase)
|
2020-09-07 22:52:29 -04:00
|
|
|
raise Discourse::NotFound if ensure_can_see && !guardian.can_see_group?(group)
|
2016-11-29 03:25:02 -05:00
|
|
|
group
|
|
|
|
end
|
2018-10-11 17:27:41 -04:00
|
|
|
|
|
|
|
def users_from_params
|
|
|
|
if params[:usernames].present?
|
2018-10-18 15:17:24 -04:00
|
|
|
users = User.where(username_lower: params[:usernames].split(",").map(&:downcase))
|
2018-10-11 17:27:41 -04:00
|
|
|
raise Discourse::InvalidParameters.new(:usernames) if users.blank?
|
2019-01-24 19:28:48 -05:00
|
|
|
elsif params[:user_id].present?
|
|
|
|
users = User.where(id: params[:user_id].to_i)
|
|
|
|
raise Discourse::InvalidParameters.new(:user_id) if users.blank?
|
2018-10-11 17:27:41 -04:00
|
|
|
elsif params[:user_ids].present?
|
2019-01-24 19:28:48 -05:00
|
|
|
users = User.where(id: params[:user_ids].to_s.split(","))
|
2018-10-11 17:27:41 -04:00
|
|
|
raise Discourse::InvalidParameters.new(:user_ids) if users.blank?
|
|
|
|
elsif params[:user_emails].present?
|
|
|
|
users = User.with_email(params[:user_emails].split(","))
|
|
|
|
raise Discourse::InvalidParameters.new(:user_emails) if users.blank?
|
|
|
|
else
|
2020-08-04 11:02:01 -04:00
|
|
|
users = []
|
2018-10-11 17:27:41 -04:00
|
|
|
end
|
|
|
|
users
|
|
|
|
end
|
FEATURE: Improve group email settings UI (#13083)
This overhauls the user interface for the group email settings management, aiming to make it a lot easier to test the settings entered and confirm they are correct before proceeding. We do this by forcing the user to test the settings before they can be saved to the database. It also includes some quality of life improvements around setting up IMAP and SMTP for our first supported provider, GMail. This PR does not remove the old group email config, that will come in a subsequent PR. This is related to https://meta.discourse.org/t/imap-support-for-group-inboxes/160588 so read that if you would like more backstory.
### UI
Both site settings of `enable_imap` and `enable_smtp` must be true to test this. You must enable SMTP first to enable IMAP.
You can prefill the SMTP settings with GMail configuration. To proceed with saving these settings you must test them, which is handled by the EmailSettingsValidator.
If there is an issue with the configuration or credentials a meaningful error message should be shown.
IMAP settings must also be validated when IMAP is enabled, before saving.
When saving IMAP, we fetch the mailboxes for that account and populate them. This mailbox must be selected and saved for IMAP to work (the feature acts as though it is disabled until the mailbox is selected and saved):
### Database & Backend
This adds several columns to the Groups table. The purpose of this change is to make it much more explicit that SMTP/IMAP is enabled for a group, rather than relying on settings not being null. Also included is an UPDATE query to backfill these columns. These columns are automatically filled when updating the group.
For GMail, we now filter the mailboxes returned. This is so users cannot use a mailbox like Sent or Trash for syncing, which would generally be disastrous.
There is a new group endpoint for testing email settings. This may be useful in the future for other places in our UI, at which point it can be extracted to a more generic endpoint or module to be included.
2021-05-27 19:28:18 -04:00
|
|
|
|
|
|
|
def clear_disabled_email_settings(group, params_with_permitted)
|
|
|
|
should_clear_imap = group.imap_enabled && params_with_permitted.key?(:imap_enabled) && params_with_permitted[:imap_enabled] == "false"
|
|
|
|
should_clear_smtp = group.smtp_enabled && params_with_permitted.key?(:smtp_enabled) && params_with_permitted[:smtp_enabled] == "false"
|
|
|
|
|
|
|
|
if should_clear_imap || should_clear_smtp
|
|
|
|
params_with_permitted[:imap_server] = nil
|
|
|
|
params_with_permitted[:imap_ssl] = false
|
|
|
|
params_with_permitted[:imap_port] = nil
|
|
|
|
params_with_permitted[:imap_mailbox_name] = ""
|
|
|
|
end
|
|
|
|
|
|
|
|
if should_clear_smtp
|
|
|
|
params_with_permitted[:smtp_server] = nil
|
|
|
|
params_with_permitted[:smtp_ssl] = false
|
|
|
|
params_with_permitted[:smtp_port] = nil
|
|
|
|
params_with_permitted[:email_username] = nil
|
|
|
|
params_with_permitted[:email_password] = nil
|
|
|
|
end
|
|
|
|
end
|
2021-07-15 10:23:57 -04:00
|
|
|
|
|
|
|
def user_default_notifications(group, params)
|
|
|
|
category_notifications = group.group_category_notification_defaults.pluck(:category_id, :notification_level).to_h
|
|
|
|
tag_notifications = group.group_tag_notification_defaults.pluck(:tag_id, :notification_level).to_h
|
|
|
|
categories = {}
|
|
|
|
tags = {}
|
|
|
|
|
|
|
|
NotificationLevels.all.each do |key, value|
|
|
|
|
category_ids = (params["#{key}_category_ids".to_sym] || []) - ["-1"]
|
|
|
|
|
|
|
|
category_ids.each do |category_id|
|
|
|
|
category_id = category_id.to_i
|
|
|
|
old_value = category_notifications[category_id]
|
|
|
|
|
|
|
|
metadata = {
|
|
|
|
old_value: old_value,
|
|
|
|
new_value: value
|
|
|
|
}
|
|
|
|
|
|
|
|
if old_value.blank?
|
|
|
|
metadata[:action] = :create
|
|
|
|
elsif old_value == value
|
|
|
|
category_notifications.delete(category_id)
|
|
|
|
next
|
|
|
|
else
|
|
|
|
metadata[:action] = :update
|
|
|
|
end
|
|
|
|
|
|
|
|
categories[category_id] = metadata
|
|
|
|
end
|
|
|
|
|
|
|
|
tag_names = (params["#{key}_tags".to_sym] || []) - ["-1"]
|
|
|
|
tag_ids = Tag.where(name: tag_names).pluck(:id)
|
|
|
|
|
|
|
|
tag_ids.each do |tag_id|
|
|
|
|
old_value = tag_notifications[tag_id]
|
|
|
|
|
|
|
|
metadata = {
|
|
|
|
old_value: old_value,
|
|
|
|
new_value: value
|
|
|
|
}
|
|
|
|
|
|
|
|
if old_value.blank?
|
|
|
|
metadata[:action] = :create
|
|
|
|
elsif old_value == value
|
|
|
|
tag_notifications.delete(tag_id)
|
|
|
|
next
|
|
|
|
else
|
|
|
|
metadata[:action] = :update
|
|
|
|
end
|
|
|
|
|
|
|
|
tags[tag_id] = metadata
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
(category_notifications.keys - categories.keys).each do |category_id|
|
|
|
|
categories[category_id] = { action: :delete, old_value: category_notifications[category_id] }
|
|
|
|
end
|
|
|
|
|
|
|
|
(tag_notifications.keys - tags.keys).each do |tag_id|
|
|
|
|
tags[tag_id] = { action: :delete, old_value: tag_notifications[tag_id] }
|
|
|
|
end
|
|
|
|
|
2021-08-31 06:41:26 -04:00
|
|
|
notification_level = nil
|
|
|
|
default_notification_level = params[:default_notification_level]&.to_i
|
|
|
|
|
|
|
|
if default_notification_level.present? && group.default_notification_level != default_notification_level
|
|
|
|
notification_level = {
|
|
|
|
old_value: group.default_notification_level,
|
|
|
|
new_value: default_notification_level
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
[notification_level, categories, tags]
|
2021-07-15 10:23:57 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
%i{
|
|
|
|
count
|
|
|
|
update
|
|
|
|
}.each do |action|
|
2021-08-31 06:41:26 -04:00
|
|
|
define_method("#{action}_existing_users") do |group_users, notification_level, categories, tags|
|
|
|
|
return 0 if notification_level.blank? && categories.blank? && tags.blank?
|
2021-07-15 10:23:57 -04:00
|
|
|
|
|
|
|
ids = []
|
|
|
|
|
2021-08-31 06:41:26 -04:00
|
|
|
if notification_level.present?
|
|
|
|
users = group_users.where(notification_level: notification_level[:old_value])
|
|
|
|
|
|
|
|
if action == :update
|
|
|
|
users.update_all(notification_level: notification_level[:new_value])
|
|
|
|
else
|
|
|
|
ids += users.pluck(:user_id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-07-15 10:23:57 -04:00
|
|
|
categories.each do |category_id, data|
|
|
|
|
if data[:action] == :update || data[:action] == :delete
|
|
|
|
category_users = CategoryUser.where(category_id: category_id, notification_level: data[:old_value], user_id: group_users.select(:user_id))
|
|
|
|
|
|
|
|
if action == :update
|
|
|
|
category_users.delete_all
|
|
|
|
else
|
|
|
|
ids += category_users.pluck(:user_id)
|
|
|
|
end
|
|
|
|
|
|
|
|
categories.delete(category_id) if data[:action] == :delete && action == :update
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
tags.each do |tag_id, data|
|
|
|
|
if data[:action] == :update || data[:action] == :delete
|
|
|
|
tag_users = TagUser.where(tag_id: tag_id, notification_level: data[:old_value], user_id: group_users.select(:user_id))
|
|
|
|
|
|
|
|
if action == :update
|
|
|
|
tag_users.delete_all
|
|
|
|
else
|
|
|
|
ids += tag_users.pluck(:user_id)
|
|
|
|
end
|
|
|
|
|
|
|
|
tags.delete(tag_id) if data[:action] == :delete && action == :update
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
if categories.present? || tags.present?
|
|
|
|
group_users.select(:id, :user_id).find_in_batches do |batch|
|
|
|
|
user_ids = batch.pluck(:user_id)
|
|
|
|
|
|
|
|
categories.each do |category_id, data|
|
|
|
|
category_users = []
|
|
|
|
existing_users = CategoryUser.where(category_id: category_id, user_id: user_ids).where("notification_level IS NOT NULL")
|
|
|
|
skip_user_ids = existing_users.pluck(:user_id)
|
|
|
|
|
|
|
|
batch.each do |group_user|
|
|
|
|
next if skip_user_ids.include?(group_user.user_id)
|
|
|
|
category_users << { category_id: category_id, user_id: group_user.user_id, notification_level: data[:new_value] }
|
|
|
|
end
|
|
|
|
|
|
|
|
next if category_users.blank?
|
|
|
|
|
|
|
|
if action == :update
|
|
|
|
CategoryUser.insert_all!(category_users)
|
|
|
|
else
|
|
|
|
ids += category_users.pluck(:user_id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
tags.each do |tag_id, data|
|
|
|
|
tag_users = []
|
|
|
|
existing_users = TagUser.where(tag_id: tag_id, user_id: user_ids).where("notification_level IS NOT NULL")
|
|
|
|
skip_user_ids = existing_users.pluck(:user_id)
|
|
|
|
|
|
|
|
batch.each do |group_user|
|
|
|
|
next if skip_user_ids.include?(group_user.user_id)
|
|
|
|
tag_users << { tag_id: tag_id, user_id: group_user.user_id, notification_level: data[:new_value], created_at: Time.now, updated_at: Time.now }
|
|
|
|
end
|
|
|
|
|
|
|
|
next if tag_users.blank?
|
|
|
|
|
|
|
|
if action == :update
|
|
|
|
TagUser.insert_all!(tag_users)
|
|
|
|
else
|
|
|
|
ids += tag_users.pluck(:user_id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
ids.uniq.count
|
|
|
|
end
|
|
|
|
end
|
2014-01-30 17:10:36 -05:00
|
|
|
end
|