2019-05-08 10:20:51 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2022-07-27 22:27:38 -04:00
|
|
|
RSpec.describe ReviewableClaimedTopicsController do
|
2019-05-08 10:20:51 -04:00
|
|
|
fab!(:moderator) { Fabricate(:moderator) }
|
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
fab!(:topic) { Fabricate(:topic) }
|
|
|
|
fab!(:reviewable) { Fabricate(:reviewable_flagged_post, topic: topic) }
|
|
|
|
|
2019-05-08 10:20:51 -04:00
|
|
|
describe '#create' do
|
2020-02-21 12:11:50 -05:00
|
|
|
let(:params) { { reviewable_claimed_topic: { topic_id: topic.id } } }
|
2019-05-08 10:20:51 -04:00
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
it "requires user to be logged in" do
|
2019-05-08 10:20:51 -04:00
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
2020-02-21 12:11:50 -05:00
|
|
|
|
|
|
|
expect(response.status).to eq(403)
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "when logged in" do
|
|
|
|
before do
|
2022-11-30 18:09:57 -05:00
|
|
|
SiteSetting.reviewable_claiming = 'optional'
|
2019-05-08 10:20:51 -04:00
|
|
|
sign_in(moderator)
|
|
|
|
end
|
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
it "works" do
|
2022-11-24 19:07:29 -05:00
|
|
|
messages = MessageBus.track_publish("/reviewable_claimed") do
|
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
end
|
2020-02-21 12:11:50 -05:00
|
|
|
|
2019-05-08 10:20:51 -04:00
|
|
|
expect(ReviewableClaimedTopic.where(user_id: moderator.id, topic_id: topic.id).exists?).to eq(true)
|
2020-02-10 18:40:01 -05:00
|
|
|
expect(topic.reviewables.first.history.where(reviewable_history_type: ReviewableHistory.types[:claimed]).size).to eq(1)
|
2020-02-21 12:11:50 -05:00
|
|
|
expect(messages.size).to eq(1)
|
2022-11-24 19:07:29 -05:00
|
|
|
|
|
|
|
message = messages[0]
|
|
|
|
|
|
|
|
expect(message.data[:topic_id]).to eq(topic.id)
|
|
|
|
expect(message.data[:user][:id]).to eq(moderator.id)
|
|
|
|
expect(message.group_ids).to contain_exactly(Group::AUTO_GROUPS[:staff])
|
|
|
|
end
|
|
|
|
|
|
|
|
it "publishes reviewable claimed changes to the category moderators of the topic's category" do
|
|
|
|
SiteSetting.enable_category_group_moderation = true
|
|
|
|
SiteSetting.reviewable_claiming = 'optional'
|
|
|
|
|
|
|
|
group = Fabricate(:group)
|
|
|
|
topic.category.update!(reviewable_by_group: group)
|
|
|
|
|
|
|
|
messages = MessageBus.track_publish("/reviewable_claimed") do
|
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(messages.size).to eq(1)
|
|
|
|
|
|
|
|
message = messages[0]
|
|
|
|
|
|
|
|
expect(message.data[:topic_id]).to eq(topic.id)
|
|
|
|
expect(message.data[:user][:id]).to eq(moderator.id)
|
|
|
|
expect(message.group_ids).to contain_exactly(Group::AUTO_GROUPS[:staff], group.id)
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
2020-01-09 12:32:05 -05:00
|
|
|
|
2020-02-25 08:49:23 -05:00
|
|
|
it "works with deleted topics" do
|
|
|
|
first_post = topic.first_post || Fabricate(:post, topic: topic)
|
|
|
|
PostDestroyer.new(Discourse.system_user, first_post).destroy
|
|
|
|
|
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
|
|
|
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(ReviewableClaimedTopic.where(user_id: moderator.id, topic_id: topic.id).exists?).to eq(true)
|
|
|
|
end
|
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
it "raises an error if user cannot claim the topic" do
|
2022-11-30 18:09:57 -05:00
|
|
|
SiteSetting.reviewable_claiming = 'disabled'
|
2020-02-21 12:11:50 -05:00
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
|
|
|
|
|
|
|
expect(response.status).to eq(403)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "raises an error if topic is already claimed" do
|
2020-01-09 12:32:05 -05:00
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
|
|
|
expect(ReviewableClaimedTopic.where(user_id: moderator.id, topic_id: topic.id).exists?).to eq(true)
|
2020-02-21 12:11:50 -05:00
|
|
|
|
2020-01-09 12:32:05 -05:00
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
2020-02-21 12:11:50 -05:00
|
|
|
expect(response.status).to eq(409)
|
2020-01-09 12:32:05 -05:00
|
|
|
end
|
2022-11-30 18:09:57 -05:00
|
|
|
|
|
|
|
it "queues a sidekiq job to refresh reviewable counts for users who can see the reviewable" do
|
2022-12-07 20:44:29 -05:00
|
|
|
SiteSetting.navigation_menu = "sidebar"
|
2022-11-30 18:09:57 -05:00
|
|
|
SiteSetting.enable_category_group_moderation = true
|
|
|
|
|
|
|
|
not_notified = Fabricate(:user)
|
|
|
|
|
|
|
|
group = Fabricate(:group)
|
|
|
|
topic.category.update!(reviewable_by_group: group)
|
|
|
|
reviewable.update!(reviewable_by_group: group)
|
|
|
|
|
|
|
|
notified = Fabricate(:user)
|
|
|
|
group.add(notified)
|
|
|
|
|
|
|
|
expect_enqueued_with(
|
|
|
|
job: :refresh_users_reviewable_counts,
|
|
|
|
args: { group_ids: [Group::AUTO_GROUPS[:staff], group.id] }
|
|
|
|
) do
|
|
|
|
post "/reviewable_claimed_topics.json", params: params
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
end
|
|
|
|
end
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#destroy' do
|
2020-02-10 18:40:01 -05:00
|
|
|
fab!(:claimed) { Fabricate(:reviewable_claimed_topic, topic: topic) }
|
2019-05-08 10:20:51 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(moderator)
|
|
|
|
end
|
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
it "works" do
|
|
|
|
SiteSetting.reviewable_claiming = 'optional'
|
|
|
|
|
2022-11-24 19:07:29 -05:00
|
|
|
messages = MessageBus.track_publish("/reviewable_claimed") do
|
|
|
|
delete "/reviewable_claimed_topics/#{claimed.topic_id}.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
end
|
2020-02-21 12:11:50 -05:00
|
|
|
|
|
|
|
expect(ReviewableClaimedTopic.where(topic_id: claimed.topic_id).exists?).to eq(false)
|
|
|
|
expect(topic.reviewables.first.history.where(reviewable_history_type: ReviewableHistory.types[:unclaimed]).size).to eq(1)
|
|
|
|
expect(messages.size).to eq(1)
|
2022-11-24 19:07:29 -05:00
|
|
|
|
|
|
|
message = messages[0]
|
|
|
|
|
|
|
|
expect(message.data[:topic_id]).to eq(topic.id)
|
|
|
|
expect(message.data[:user]).to eq(nil)
|
|
|
|
expect(message.group_ids).to contain_exactly(Group::AUTO_GROUPS[:staff])
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
|
|
|
|
2020-02-25 08:49:23 -05:00
|
|
|
it "works with deleted topics" do
|
|
|
|
SiteSetting.reviewable_claiming = 'optional'
|
|
|
|
first_post = topic.first_post || Fabricate(:post, topic: topic)
|
|
|
|
PostDestroyer.new(Discourse.system_user, first_post).destroy
|
|
|
|
|
|
|
|
delete "/reviewable_claimed_topics/#{claimed.topic_id}.json"
|
|
|
|
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(ReviewableClaimedTopic.where(user_id: moderator.id, topic_id: topic.id).exists?).to eq(false)
|
|
|
|
end
|
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
it "raises an error if topic is missing" do
|
|
|
|
delete "/reviewable_claimed_topics/111111111.json"
|
|
|
|
|
|
|
|
expect(response.status).to eq(404)
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
|
|
|
|
2020-02-21 12:11:50 -05:00
|
|
|
it "raises an error if user cannot claim the topic" do
|
2019-05-08 10:20:51 -04:00
|
|
|
delete "/reviewable_claimed_topics/#{claimed.topic_id}.json"
|
2020-02-21 12:11:50 -05:00
|
|
|
|
|
|
|
expect(response.status).to eq(403)
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
2022-11-30 18:09:57 -05:00
|
|
|
|
|
|
|
it "queues a sidekiq job to refresh reviewable counts for users who can see the reviewable" do
|
|
|
|
SiteSetting.reviewable_claiming = 'optional'
|
2022-12-07 20:44:29 -05:00
|
|
|
SiteSetting.navigation_menu = "sidebar"
|
2022-11-30 18:09:57 -05:00
|
|
|
SiteSetting.enable_category_group_moderation = true
|
|
|
|
|
|
|
|
not_notified = Fabricate(:user)
|
|
|
|
|
|
|
|
group = Fabricate(:group)
|
|
|
|
topic.category.update!(reviewable_by_group: group)
|
|
|
|
reviewable.update!(reviewable_by_group: group)
|
|
|
|
|
|
|
|
notified = Fabricate(:user)
|
|
|
|
group.add(notified)
|
|
|
|
|
|
|
|
expect_enqueued_with(
|
|
|
|
job: :refresh_users_reviewable_counts,
|
|
|
|
args: { group_ids: [Group::AUTO_GROUPS[:staff], group.id] }
|
|
|
|
) do
|
|
|
|
delete "/reviewable_claimed_topics/#{claimed.topic_id}.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
end
|
|
|
|
end
|
2019-05-08 10:20:51 -04:00
|
|
|
end
|
|
|
|
end
|