Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix flaky chat navigation specs on CI (#22560) 

Why this change?

The specs are flaky on CI and we've unable to figure out why so we've
decided to skip them only on CI for now. The tests are still ran in our
internal build so we still have some protection in place.
This commit is contained in:
Alan Guo Xiang Tan 2023-07-12 09:16:35 +08:00 committed by GitHub
parent df579ab708
commit 0106c9b4ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/chat/spec/system/navigation_spec.rb
View File

@ -143,6 +143,8 @@ RSpec.describe "Navigation", type: :system do
context "when opening a thread from the thread list" do context "when opening a thread from the thread list" do
it "goes back to the thread list when clicking the back button" do it "goes back to the thread list when clicking the back button" do
skip("Flaky on CI") if ENV["CI"]
visit("/chat") visit("/chat")
chat_page.visit_channel(category_channel) chat_page.visit_channel(category_channel)
channel_page.open_thread_list channel_page.open_thread_list
@ -157,6 +159,8 @@ RSpec.describe "Navigation", type: :system do
context "for mobile" do context "for mobile" do
it "goes back to the thread list when clicking the back button", mobile: true do it "goes back to the thread list when clicking the back button", mobile: true do
skip("Flaky on CI") if ENV["CI"]
visit("/chat") visit("/chat")
chat_page.visit_channel(category_channel) chat_page.visit_channel(category_channel)
channel_page.open_thread_list channel_page.open_thread_list
@ -173,6 +177,8 @@ RSpec.describe "Navigation", type: :system do
context "when opening a thread from indicator" do context "when opening a thread from indicator" do
it "goes back to the thread list when clicking the back button" do it "goes back to the thread list when clicking the back button" do
skip("Flaky on CI") if ENV["CI"]
visit("/chat") visit("/chat")
chat_page.visit_channel(category_channel) chat_page.visit_channel(category_channel)
channel_page.message_thread_indicator(thread.original_message).click channel_page.message_thread_indicator(thread.original_message).click
@ -186,6 +192,8 @@ RSpec.describe "Navigation", type: :system do
context "for mobile" do context "for mobile" do
it "closes the thread and goes back to the channel when clicking the back button", it "closes the thread and goes back to the channel when clicking the back button",
mobile: true do mobile: true do
skip("Flaky on CI") if ENV["CI"]
visit("/chat") visit("/chat")
chat_page.visit_channel(category_channel) chat_page.visit_channel(category_channel)
channel_page.message_thread_indicator(thread.original_message).click channel_page.message_thread_indicator(thread.original_message).click