FIX: Sharing buttons broke in 1.9 template upgrade

app/assets/javascripts/discourse/templates/share.hbs

@@ -11,8 +11,7 @@
 </div>
 
 {{each s in shareLinks itemView='share-link'}}
-
 <div class='link'>
-  <a href='#' {{action "close"}} title='{{i18n 'share.close'}}'><i class="fa fa-times-circle"></i></a>
+  <a href {{action "close"}} title='{{i18n 'share.close'}}'><i class="fa fa-times-circle"></i></a>
 </div>
 {{/if}}

app/assets/javascripts/discourse/templates/share_link.hbs

@@ -1,5 +1,5 @@
-{{#if openInPopup}}
-  <a href="#" {{action "sharePopup" target href}} {{bind-attr title="title"}}><i {{bind-attr class=":fa iconClass"}}></i></a>
+{{#if s.openInPopup}}
+  <a href {{action "sharePopup" s.target s.href}} {{bind-attr title="title"}}><i {{bind-attr class=":fa s.iconClass"}}></i></a>
 {{else}}
-  <a {{bind-attr href="href"}} {{bind-attr title="title"}} target="_blank"><i {{bind-attr class=":fa iconClass"}}></i></a>
+  <a {{bind-attr href="s.href"}} {{bind-attr title="s.title"}} target="_blank"><i {{bind-attr class=":fa s.iconClass"}}></i></a>
 {{/if}}

app/assets/javascripts/discourse/views/share-link.js.es6

@@ -1,12 +1,3 @@
-/**
-  This view handles rendering of a link to share something on a
-  third-party site.
-
-  @class ShareLinkView
-  @extends Discourse.View
-  @namespace Discourse
-  @module Discourse
-**/
 export default Ember.View.extend({
   templateName: 'share_link',
   tagName: 'div',