Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Sharing buttons broke in 1.9 template upgrade

This commit is contained in:
Robin Ward 2014-12-19 15:26:05 -05:00
parent 1d74e3c663
commit 043a93dfd5
3 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/templates/share.hbs
View File

@ -11,8 +11,7 @@
</div> </div>
{{each s in shareLinks itemView='share-link'}} {{each s in shareLinks itemView='share-link'}}
<div class='link'> <div class='link'>
<a href='#' {{action "close"}} title='{{i18n 'share.close'}}'><i class="fa fa-times-circle"></i></a> <a href {{action "close"}} title='{{i18n 'share.close'}}'><i class="fa fa-times-circle"></i></a>
</div> </div>
{{/if}} {{/if}}

6
app/assets/javascripts/discourse/templates/share_link.hbs
View File

@ -1,5 +1,5 @@
{{#if openInPopup}} {{#if s.openInPopup}}
<a href="#" {{action "sharePopup" target href}} {{bind-attr title="title"}}><i {{bind-attr class=":fa iconClass"}}></i></a> <a href {{action "sharePopup" s.target s.href}} {{bind-attr title="title"}}><i {{bind-attr class=":fa s.iconClass"}}></i></a>
{{else}} {{else}}
<a {{bind-attr href="href"}} {{bind-attr title="title"}} target="_blank"><i {{bind-attr class=":fa iconClass"}}></i></a> <a {{bind-attr href="s.href"}} {{bind-attr title="s.title"}} target="_blank"><i {{bind-attr class=":fa s.iconClass"}}></i></a>
{{/if}} {{/if}}

9
app/assets/javascripts/discourse/views/share-link.js.es6
View File

@ -1,12 +1,3 @@
/**
This view handles rendering of a link to share something on a
third-party site.
@class ShareLinkView
@extends Discourse.View
@namespace Discourse
@module Discourse
**/
export default Ember.View.extend({ export default Ember.View.extend({
templateName: 'share_link', templateName: 'share_link',
tagName: 'div', tagName: 'div',