From 04a3b949a4d637acb503e31bafb38a71d7337eba Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Wed, 29 Jul 2020 16:42:24 +1000 Subject: [PATCH] FIX: add protection when removing auto delete on post bookmarks If you reply to a topic and are looking at an admin page (like site settings) ,you have no postStream or posts. --- .../discourse/app/controllers/topic.js | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/app/assets/javascripts/discourse/app/controllers/topic.js b/app/assets/javascripts/discourse/app/controllers/topic.js index 1be8e37ef74..49467d5a30e 100644 --- a/app/assets/javascripts/discourse/app/controllers/topic.js +++ b/app/assets/javascripts/discourse/app/controllers/topic.js @@ -189,17 +189,19 @@ export default Controller.extend(bufferedProperty("model"), { }, _removeDeleteOnOwnerReplyBookmarks() { - let posts = this.model.get("postStream").posts; - posts - .filter( - p => - p.bookmarked && - p.bookmark_auto_delete_preference === - AUTO_DELETE_PREFERENCES.ON_OWNER_REPLY - ) - .forEach(p => { - p.clearBookmark(); - }); + const posts = this.get("model.postStream.posts"); + if (posts) { + posts + .filter( + p => + p.bookmarked && + p.bookmark_auto_delete_preference === + AUTO_DELETE_PREFERENCES.ON_OWNER_REPLY + ) + .forEach(p => { + p.clearBookmark(); + }); + } }, _forceRefreshPostStream() {