PERF: Prefer joins over subquery for `User#private_posts_for_user`.

The subquery here prevents the planner from optimizing the query. As
such, we prefer joining against the requried tables instead.
This commit is contained in:
Guo Xiang Tan 2020-08-17 14:47:48 +08:00
parent 248bebb8cd
commit 05b43e5ae4
No known key found for this signature in database
GPG Key ID: FBD110179AAC1F20
1 changed files with 4 additions and 1 deletions

View File

@ -80,7 +80,10 @@ class Post < ActiveRecord::Base
register_custom_field_type(MISSING_UPLOADS_IGNORED, :boolean)
scope :private_posts_for_user, ->(user) {
where("posts.topic_id IN (#{Topic::PRIVATE_MESSAGES_SQL})", user_id: user.id)
joins("LEFT JOIN topic_allowed_users ON topic_allowed_users.topic_id = posts.topic_id AND topic_allowed_users.user_id = #{user.id.to_i}")
.joins("LEFT JOIN group_users ON group_users.user_id = #{user.id.to_i}")
.joins("LEFT JOIN topic_allowed_groups ON topic_allowed_groups.topic_id = posts.topic_id AND topic_allowed_groups.group_id = group_users.group_id")
.where("topic_allowed_users.topic_id IS NOT NULL OR topic_allowed_groups.topic_id IS NOT NULL")
}
scope :by_newest, -> { order('created_at DESC, id DESC') }