Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Skip length check on reply drafts (#17408) 

We don't count quote characters as part of the reply length.

We don't save drafts if the reply length is less than the min_post_length site setting.

If you start a reply that only contains a bunch of quotes with the intent to continue later, you get no draft.

This PR fixes that.

Note that we still don't save drafts if the composer is completely empty or if you're composing a new topic. This only affects replies.

This PR only changes the behavior if the reply composer contains something regardless of whether that something is a quote or not and ignores the min_post_length site setting.
This commit is contained in:
Joe 2022-07-10 13:54:40 +08:00 committed by GitHub
parent 4f18f3ac20
commit 06ae9229e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/app/models/composer.js
View File

@ -1211,11 +1211,6 @@ const Composer = RestModel.extend({
if (isEmpty(this.reply)) { if (isEmpty(this.reply)) {
return false; return false;
} }
// Do not save when the reply's length is too small
if (this.replyLength < this.minimumPostLength) {
return false;
}
} }
return true; return true;

10
app/assets/javascripts/discourse/tests/acceptance/composer-test.js
View File

@ -912,6 +912,16 @@ acceptance("Composer", function (needs) {
await click(".save-or-cancel .cancel"); await click(".save-or-cancel .cancel");
assert.notOk(exists(".discard-draft-modal .save-draft")); assert.notOk(exists(".discard-draft-modal .save-draft"));
}); });
test("Saves drafts that only contain quotes", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("#topic-footer-buttons .create");
await fillIn(".d-editor-input", "[quote]some quote[/quote]");
await click(".save-or-cancel .cancel");
assert.ok(exists(".discard-draft-modal .save-draft"));
});
}); });
acceptance("Composer - Customizations", function (needs) { acceptance("Composer - Customizations", function (needs) {