Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix png optimization test flakyness (#19535) 

* DEV: Fix png optimization test flakyness

Update fixture with oxipng 7

This test broke when the pngoptimizer got better so the pre-optimized png in the fixtures was compressed further on upload creation, breaking the expected size.
This commit is contained in:
Rafael dos Santos Silva 2022-12-20 16:05:14 -03:00 committed by GitHub
parent 318ebdf7e0
commit 06ff15f3ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
spec/fixtures/images/pngquant.png vendored
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 9.3 KiB

After

Width:  |  Height:  |  Size: 9.0 KiB

2
spec/lib/upload_creator_spec.rb
View File

@ -139,7 +139,7 @@ RSpec.describe UploadCreator do
).create_for(user.id) ).create_for(user.id)
# no optimisation possible without losing details # no optimisation possible without losing details
expect(upload.filesize).to eq(9558) expect(upload.filesize).to eq(9202)
thumbnail_size = upload.get_optimized_image(upload.width, upload.height, {}).filesize thumbnail_size = upload.get_optimized_image(upload.width, upload.height, {}).filesize