Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Remove up/down key bindings for search results 

Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
This commit is contained in:
cpradio 2014-08-28 21:39:19 -04:00
parent 3e7084743c
commit 0784c52a24
2 changed files with 1 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/views/search-results-type.js.es6
View File

@ -3,7 +3,6 @@ export default Ember.CollectionView.extend({
itemViewClass: Discourse.GroupedView.extend({ itemViewClass: Discourse.GroupedView.extend({
tagName: 'li', tagName: 'li',
classNameBindings: ['selected'], classNameBindings: ['selected'],
templateName: Discourse.computed.fmt('parentView.type', "search/%@_result"), templateName: Discourse.computed.fmt('parentView.type', "search/%@_result")
selected: Discourse.computed.propertyEqual('content.index', 'controller.selectedIndex')
}) })
}); });

23
app/assets/javascripts/discourse/views/search.js.es6
View File

@ -3,27 +3,4 @@ export default Discourse.View.extend({
classNames: ['d-dropdown'], classNames: ['d-dropdown'],
elementId: 'search-dropdown', elementId: 'search-dropdown',
templateName: 'search' templateName: 'search'
// didInsertElement: function() {
// // Delegate ESC to the composer
// var controller = this.get('controller');
// return $('body').on('keydown.search', function(e) {
// if ($('#search-dropdown').is(':visible')) {
// switch (e.which) {
// case 13:
// controller.select();
// e.preventDefault();
// break;
// case 38:
// controller.moveUp();
// e.preventDefault();
// break;
// case 40:
// controller.moveDown();
// e.preventDefault();
// break;
// }
// }
// });
// }
}); });