Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Requests were not being logged correctly 

`enable` was defaulting to `nil` which is not what we wanted.
This commit is contained in:
Robin Ward 2020-05-20 15:09:17 -04:00
parent e1bd57007b
commit 096eca0ee8
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/models/application_request.rb
View File

@ -16,15 +16,16 @@ class ApplicationRequest < ActiveRecord::Base
include CachedCounting include CachedCounting
def self.disable def self.disable
@enabled = false @disabled = true
end end
def self.enable def self.enable
@enabled = true @disabled = false
end end
def self.increment!(type, opts = nil) def self.increment!(type, opts = nil)
perform_increment!(redis_key(type), opts) if @enabled return if @disabled
perform_increment!(redis_key(type), opts)
end end
def self.write_cache!(date = nil) def self.write_cache!(date = nil)

3
spec/rails_helper.rb
View File

@ -128,6 +128,9 @@ module TestSetup
# code that runs inside jobs. run_later! means they are put on the redis # code that runs inside jobs. run_later! means they are put on the redis
# queue and never processed. # queue and never processed.
Jobs.run_later! Jobs.run_later!
# Don't track ApplicationRequests in test mode unless opted in
ApplicationRequest.disable
end end
end end