From 09b0548b5f7658ecf0a7035a6105ebbe26b82078 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Fri, 17 Nov 2023 14:28:06 +1000 Subject: [PATCH] DEV: Fix S3 minio specs on CI (#24426) config.after(:suite) which stops minio server is called every time one of the groups of parallel tests complete. This works fine most of the time with parallel spec runs, but sometimes one of these MinioRunner.stop calls happens while a spec is running in another process that expects the minio server to be running. Skipping these tests to avoid flakys for now. --- spec/support/system_helpers.rb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/spec/support/system_helpers.rb b/spec/support/system_helpers.rb index d2e0a4c2748..860325024d4 100644 --- a/spec/support/system_helpers.rb +++ b/spec/support/system_helpers.rb @@ -199,6 +199,13 @@ module SystemHelpers end def skip_unless_s3_system_specs_enabled! + if ENV["CI"] + return( + skip( + "S3 system specs are temporarily disabled in this environment to address parallel spec issues", + ) + ) + end if !ENV["CI"] && !ENV["RUN_S3_SYSTEM_SPECS"] skip( "S3 system specs are disabled in this environment, set CI=1 or RUN_S3_SYSTEM_SPECS=1 to enable them.",