From 0d84f3afd4f7e44d326357f1f53ed3b9c1033521 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Thu, 30 Apr 2020 14:36:21 +0200 Subject: [PATCH] UX: adds title attribute to widget dropdown header (#9597) --- .../discourse/app/widgets/widget-dropdown.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/app/widgets/widget-dropdown.js b/app/assets/javascripts/discourse/app/widgets/widget-dropdown.js index 0b26f8d727d..dbb34a5e645 100644 --- a/app/assets/javascripts/discourse/app/widgets/widget-dropdown.js +++ b/app/assets/javascripts/discourse/app/widgets/widget-dropdown.js @@ -56,9 +56,11 @@ export const WidgetDropdownHeaderClass = { tagName: "button", transform(attrs) { - return { - label: attrs.translatedLabel ? attrs.translatedLabel : I18n.t(attrs.label) - }; + return { label: this._buildLabel(attrs) }; + }, + + buildAttributes(attrs) { + return { title: this._buildLabel(attrs) }; }, buildClasses(attrs) { @@ -85,7 +87,11 @@ export const WidgetDropdownHeaderClass = { {{#if attrs.caret}} {{d-icon "caret-down"}} {{/if}} - ` + `, + + _buildLabel(attrs) { + return attrs.translatedLabel ? attrs.translatedLabel : I18n.t(attrs.label); + } }; createWidget("widget-dropdown-header", WidgetDropdownHeaderClass);