FIX: Set user timezone on password reset login (#9461)

This commit is contained in:
Mark VanLandingham 2020-04-17 13:39:04 -05:00 committed by GitHub
parent 80563705da
commit 0e74dd7d7c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 1 deletions

View File

@ -54,7 +54,8 @@ export default Controller.extend(PasswordValidation, {
password: this.accountPassword, password: this.accountPassword,
second_factor_token: second_factor_token:
this.securityKeyCredential || this.secondFactorToken, this.securityKeyCredential || this.secondFactorToken,
second_factor_method: this.secondFactorMethod second_factor_method: this.secondFactorMethod,
timezone: moment.tz.guess()
} }
}) })
.then(result => { .then(result => {

View File

@ -641,6 +641,7 @@ class UsersController < ApplicationController
# if we have run into no errors then the user is a-ok to # if we have run into no errors then the user is a-ok to
# change the password # change the password
if @user.errors.empty? if @user.errors.empty?
@user.update_timezone_if_missing(params[:timezone]) if params[:timezone]
@user.password = params[:password] @user.password = params[:password]
@user.password_required! @user.password_required!
@user.user_auth_tokens.destroy_all @user.user_auth_tokens.destroy_all

View File

@ -279,6 +279,18 @@ describe UsersController do
expect(response).to redirect_to(wizard_path) expect(response).to redirect_to(wizard_path)
end end
it "sets the users timezone if the param is present" do
user = Fabricate(:admin)
UserAuthToken.generate!(user_id: user.id)
token = user.email_tokens.create(email: user.email).token
get "/u/password-reset/#{token}"
expect(user.user_option.timezone).to eq(nil)
put "/u/password-reset/#{token}", params: { password: 'hg9ow8yhg98oadminlonger', timezone: "America/Chicago" }
expect(user.user_option.reload.timezone).to eq("America/Chicago")
end
it "logs the password change" do it "logs the password change" do
user = Fabricate(:admin) user = Fabricate(:admin)
UserAuthToken.generate!(user_id: user.id) UserAuthToken.generate!(user_id: user.id)