diff --git a/app/models/group.rb b/app/models/group.rb index d99fb257212..0988cc3303a 100644 --- a/app/models/group.rb +++ b/app/models/group.rb @@ -750,7 +750,7 @@ class Group < ActiveRecord::Base end def flair_url - flair_icon.presence || flair_upload&.url + flair_icon.presence || flair_upload&.short_path end protected diff --git a/spec/jobs/migrate_group_flair_images_spec.rb b/spec/jobs/migrate_group_flair_images_spec.rb index ff3428fc989..cc72d26fa21 100644 --- a/spec/jobs/migrate_group_flair_images_spec.rb +++ b/spec/jobs/migrate_group_flair_images_spec.rb @@ -28,7 +28,9 @@ RSpec.describe Jobs::MigrateGroupFlairImages do end.to change { Upload.count }.by(1) group.reload - expect(group.flair_upload).to eq(Upload.last) + upload = Upload.last + expect(group.flair_upload).to eq(upload) + expect(group.flair_url).to eq(upload.short_path) expect(group[:flair_url]).to eq(nil) end