From 113cb4d3ad3ec950bcbb12619619b55cc2f16ec0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Hanol?= Date: Tue, 8 Sep 2015 10:34:36 +0200 Subject: [PATCH] FIX: '@observes' doesn't work that way --- .../javascripts/discourse/components/popup-input-tip.js.es6 | 4 ++-- app/assets/javascripts/discourse/components/user-menu.js.es6 | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/components/popup-input-tip.js.es6 b/app/assets/javascripts/discourse/components/popup-input-tip.js.es6 index 48d49e6109c..51725abc09e 100644 --- a/app/assets/javascripts/discourse/components/popup-input-tip.js.es6 +++ b/app/assets/javascripts/discourse/components/popup-input-tip.js.es6 @@ -17,8 +17,8 @@ export default Ember.Component.extend(StringBuffer, { good: Ember.computed.not("bad"), @observes("shownAt") - bounce(shownAt) { - if (shownAt) { + bounce() { + if (this.get("shownAt")) { var $elem = this.$(); if (!this.animateAttribute) { this.animateAttribute = $elem.css('left') === 'auto' ? 'right' : 'left'; diff --git a/app/assets/javascripts/discourse/components/user-menu.js.es6 b/app/assets/javascripts/discourse/components/user-menu.js.es6 index 78438193cd7..b1c14d2d79a 100644 --- a/app/assets/javascripts/discourse/components/user-menu.js.es6 +++ b/app/assets/javascripts/discourse/components/user-menu.js.es6 @@ -18,8 +18,8 @@ export default Ember.Component.extend({ showDisableAnon(allowAnon, isAnon) { return allowAnon && isAnon; }, @observes('visible') - _loadNotifications(visible) { - if (visible) { + _loadNotifications() { + if (this.get("visible")) { this.refreshNotifications(); } },