Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: cache messages so re-opening composer on same topic does not issue a req

This commit is contained in:
Sam 2018-01-10 14:39:39 +11:00
parent 3ed9cbc040
commit 114294d899
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/assets/javascripts/discourse/components/composer-messages.js.es6
View File

@ -1,5 +1,7 @@
import LinkLookup from 'discourse/lib/link-lookup'; import LinkLookup from 'discourse/lib/link-lookup';
let _messagesCache = {};
export default Ember.Component.extend({ export default Ember.Component.extend({
classNameBindings: [':composer-popup-container', 'hidden'], classNameBindings: [':composer-popup-container', 'hidden'],
checkedMessages: false, checkedMessages: false,
@ -165,7 +167,9 @@ export default Ember.Component.extend({
if (topicId) { args.topic_id = topicId; } if (topicId) { args.topic_id = topicId; }
if (postId) { args.post_id = postId; } if (postId) { args.post_id = postId; }
composer.store.find('composer-message', args).then(messages => { const cacheKey = `${args.composer_action}${args.topic_id}${args.post_id}`;
const processMessages = messages => {
if (this.isDestroying || this.isDestroyed) { return; } if (this.isDestroying || this.isDestroyed) { return; }
// Checking composer messages on replies can give us a list of links to check for // Checking composer messages on replies can give us a list of links to check for
@ -177,6 +181,15 @@ export default Ember.Component.extend({
this.set('checkedMessages', true); this.set('checkedMessages', true);
const queuedForTyping = this.get('queuedForTyping'); const queuedForTyping = this.get('queuedForTyping');
messages.forEach(msg => msg.wait_for_typing ? queuedForTyping.addObject(msg) : this.send('popup', msg)); messages.forEach(msg => msg.wait_for_typing ? queuedForTyping.addObject(msg) : this.send('popup', msg));
};
if (_messagesCache.cacheKey === cacheKey) {
processMessages(_messagesCache.messages);
} else {
composer.store.find('composer-message', args).then(messages => {
_messagesCache = {messages, cacheKey};
processMessages(messages);
}); });
} }
}
}); });