From 11921c4868051db68b0aadae36926da99a2a95cd Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Thu, 12 Mar 2020 07:51:05 +0100 Subject: [PATCH] DEV: enforces ember-template-lint: no-html-comments (#9183) https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-html-comments.md --- .template-lintrc.js | 3 ++- .../templates/modal/admin-badge-preview.hbs | 18 +++++++++--------- .../components/search-advanced-options.hbs | 5 ++--- .../discourse/templates/modal/bookmark.hbs | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.template-lintrc.js b/.template-lintrc.js index 801225fd338..17279244f34 100644 --- a/.template-lintrc.js +++ b/.template-lintrc.js @@ -13,6 +13,7 @@ module.exports = { "no-unbound": true, "simple-unless": true, "no-triple-curlies": true, - "no-partial": true + "no-partial": true, + "no-html-comments": true } }; diff --git a/app/assets/javascripts/admin/templates/modal/admin-badge-preview.hbs b/app/assets/javascripts/admin/templates/modal/admin-badge-preview.hbs index 528ed5af240..eaab7e615f5 100644 --- a/app/assets/javascripts/admin/templates/modal/admin-badge-preview.hbs +++ b/app/assets/javascripts/admin/templates/modal/admin-badge-preview.hbs @@ -4,15 +4,15 @@
{{errors}}
- + {{!-- + TODO we want some help pages for this, link to those instead +

+ {{i18n "admin.badges.preview.error_help"}} +

+ + --}} {{else}}

diff --git a/app/assets/javascripts/discourse/templates/components/search-advanced-options.hbs b/app/assets/javascripts/discourse/templates/components/search-advanced-options.hbs index 36e1b5a4cbb..89df8f94e37 100644 --- a/app/assets/javascripts/discourse/templates/components/search-advanced-options.hbs +++ b/app/assets/javascripts/discourse/templates/components/search-advanced-options.hbs @@ -24,7 +24,7 @@ - + --}} {{#if siteSettings.tagging_enabled}}

diff --git a/app/assets/javascripts/discourse/templates/modal/bookmark.hbs b/app/assets/javascripts/discourse/templates/modal/bookmark.hbs index 4fb9e462f9f..782ebe9cabe 100644 --- a/app/assets/javascripts/discourse/templates/modal/bookmark.hbs +++ b/app/assets/javascripts/discourse/templates/modal/bookmark.hbs @@ -57,7 +57,7 @@
{{d-button label="bookmarks.save" class="btn-primary" action=(action "saveAndClose")}} - {{d-modal-cancel close=(action "closeWithoutSavingBookmark")}} + {{d-modal-cancel close=(action "closeWithoutSavingBookmark")}}
{{/conditional-loading-spinner}} {{/d-modal-body}}