Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Don't check the `defaultState` every time a widget is rendered 

This only happens in development mode but still ends up calling the
method unnecessarily.
This commit is contained in:
Robin Ward 2021-09-08 17:10:02 -04:00
parent 0532a5a43e
commit 1205db8f84
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/assets/javascripts/discourse/app/widgets/widget.js
View File

@ -155,16 +155,6 @@ export default class Widget {
this.init(this.attrs);
// Helps debug widgets
if (!isProduction()) {
const ds = this.defaultState(attrs);
if (typeof ds !== "object") {
throw new Error(`defaultState must return an object`);
} else if (Object.keys(ds).length > 0 && !this.key) {
throw new Error(`you need a key when using state in ${this.name}`);
}
}
if (this.name) {
const custom = _customSettings[this.name];
if (custom) {
@ -195,7 +185,15 @@ export default class Widget {
if (prev && prev.key && prev.key === this.key) {
this.state = prev.state;
} else {
// Helps debug widgets
this.state = this.defaultState(this.attrs, this.state);
if (!isProduction()) {
if (typeof this.state !== "object") {
throw new Error(`defaultState must return an object`);
} else if (Object.keys(this.state).length > 0 && !this.key) {
throw new Error(`you need a key when using state in ${this.name}`);
}
}
}
// Sometimes we pass state down from the parent