Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Don't use `Dir.chdir()` (#16535) 

`system()` provides `chdir:` option for that.
This commit is contained in:
Jarek Radosz 2022-04-22 11:17:10 +02:00 committed by GitHub
parent dba7a1d8ed
commit 1209d51a7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/tasks/qunit.rake
View File

@ -1,7 +1,6 @@
# frozen_string_literal: true # frozen_string_literal: true
desc "Runs the qunit test suite" desc "Runs the qunit test suite"
task "qunit:test", [:timeout, :qunit_path] do |_, args| task "qunit:test", [:timeout, :qunit_path] do |_, args|
require "socket" require "socket"
require "chrome_installed_checker" require "chrome_installed_checker"
@ -107,11 +106,9 @@ task "qunit:test", [:timeout, :qunit_path] do |_, args|
puts "Rails server is warmed up" puts "Rails server is warmed up"
if ember_cli if ember_cli
Dir.chdir("#{Rails.root}/app/assets/javascripts/discourse") do # rubocop:disable Discourse/NoChdir because this is not part of the app cmd = ["env", "UNICORN_PORT=#{unicorn_port}", "yarn", "ember", "test", "--query", query]
cmd = ["env", "UNICORN_PORT=#{unicorn_port}", "yarn", "ember", "test", "--query", query] cmd += ["--test-page", qunit_path.delete_prefix("/")] if qunit_path
cmd += ["--test-page", qunit_path.delete_prefix("/")] if qunit_path system(*cmd, chdir: "#{Rails.root}/app/assets/javascripts/discourse")
system(*cmd)
end
else else
cmd = "node #{test_path}/run-qunit.js http://localhost:#{port}#{qunit_path}" cmd = "node #{test_path}/run-qunit.js http://localhost:#{port}#{qunit_path}"
cmd += "?#{query.gsub('+', '%20').gsub("&", '\\\&')}" cmd += "?#{query.gsub('+', '%20').gsub("&", '\\\&')}"
@ -131,5 +128,4 @@ task "qunit:test", [:timeout, :qunit_path] do |_, args|
puts "\nTests Failed" puts "\nTests Failed"
exit(1) exit(1)
end end
end end