From 132cbac6002e56bc68426efba40c0f4575c704a6 Mon Sep 17 00:00:00 2001
From: Robin Ward <robin.ward@gmail.com>
Date: Thu, 28 Sep 2017 10:21:54 -0400
Subject: [PATCH] Split out header contents for easier customization

---
 .../discourse/widgets/header-contents.js.es6  | 13 ++++
 .../discourse/widgets/header.js.es6           | 75 ++++++++++---------
 2 files changed, 53 insertions(+), 35 deletions(-)
 create mode 100644 app/assets/javascripts/discourse/widgets/header-contents.js.es6

diff --git a/app/assets/javascripts/discourse/widgets/header-contents.js.es6 b/app/assets/javascripts/discourse/widgets/header-contents.js.es6
new file mode 100644
index 00000000000..819178b6ac0
--- /dev/null
+++ b/app/assets/javascripts/discourse/widgets/header-contents.js.es6
@@ -0,0 +1,13 @@
+import { createWidget } from 'discourse/widgets/widget';
+import hbs from 'discourse/widgets/hbs-compiler';
+
+createWidget('header-contents', {
+  tagName: 'div.contents.clearfix',
+  template: hbs`
+    {{attach widget="home-logo"}}
+    <div class="panel clearfix">{{yield}}</div>
+    {{#if attrs.topic}}
+      {{attach widget="header-topic-info"}}
+    {{/if}}
+  `,
+});
diff --git a/app/assets/javascripts/discourse/widgets/header.js.es6 b/app/assets/javascripts/discourse/widgets/header.js.es6
index 1c7c1e6ce63..4c4b1e147f1 100644
--- a/app/assets/javascripts/discourse/widgets/header.js.es6
+++ b/app/assets/javascripts/discourse/widgets/header.js.es6
@@ -206,49 +206,54 @@ export default createWidget('header', {
   },
 
   html(attrs, state) {
-    const panels = [this.attach('header-buttons', attrs),
-                    this.attach('header-icons', { hamburgerVisible: state.hamburgerVisible,
-                                                  userVisible: state.userVisible,
-                                                  searchVisible: state.searchVisible,
-                                                  ringBackdrop: state.ringBackdrop,
-                                                  flagCount: attrs.flagCount,
-                                                  user: this.currentUser })];
 
-    if (state.searchVisible) {
-      const contextType = this.searchContextType();
+    let contents = () => {
+      const panels = [
+        this.attach('header-buttons', attrs),
+        this.attach('header-icons', {
+          hamburgerVisible: state.hamburgerVisible,
+          userVisible: state.userVisible,
+          searchVisible: state.searchVisible,
+          ringBackdrop: state.ringBackdrop,
+          flagCount: attrs.flagCount,
+          user: this.currentUser }
+        )
+      ];
 
-      if (state.searchContextType !== contextType) {
-        state.contextEnabled = undefined;
-        state.searchContextType = contextType;
-      }
+      if (state.searchVisible) {
+        const contextType = this.searchContextType();
 
-      if (state.contextEnabled === undefined) {
-        if (forceContextEnabled.includes(contextType)) {
-          state.contextEnabled = true;
+        if (state.searchContextType !== contextType) {
+          state.contextEnabled = undefined;
+          state.searchContextType = contextType;
         }
+
+        if (state.contextEnabled === undefined) {
+          if (forceContextEnabled.includes(contextType)) {
+            state.contextEnabled = true;
+          }
+        }
+
+        panels.push(this.attach('search-menu', { contextEnabled: state.contextEnabled }));
+      } else if (state.hamburgerVisible) {
+        panels.push(this.attach('hamburger-menu'));
+      } else if (state.userVisible) {
+        panels.push(this.attach('user-menu'));
       }
 
-      panels.push(this.attach('search-menu', { contextEnabled: state.contextEnabled }));
-    } else if (state.hamburgerVisible) {
-      panels.push(this.attach('hamburger-menu'));
-    } else if (state.userVisible) {
-      panels.push(this.attach('user-menu'));
-    }
+      additionalPanels.map((panel) => {
+        if (this.state[panel.toggle]) {
+          panels.push(this.attach(panel.name, panel.transformAttrs.call(this, attrs, state)));
+        }
+      });
 
-    additionalPanels.map((panel) => {
-      if (this.state[panel.toggle]) {
-        panels.push(this.attach(panel.name, panel.transformAttrs.call(this, attrs, state)));
-      }
-    });
+      return panels;
+    };
 
-    const contents = [ this.attach('home-logo', { minimized: !!attrs.topic }),
-                       h('div.panel.clearfix', panels) ];
-
-    if (attrs.topic) {
-      contents.push(this.attach('header-topic-info', attrs));
-    }
-
-    return h('div.wrap', h('div.contents.clearfix', contents));
+    let contentsAttrs = { contents, minimized: !!attrs.topic };
+    return h('div.wrap',
+      this.attach('header-contents', $.extend({}, attrs, contentsAttrs))
+    );
   },
 
   updateHighlight() {