From 140d9aadfef9851c33c350af0be99b2a78089332 Mon Sep 17 00:00:00 2001
From: Jarek Radosz <jradosz@gmail.com>
Date: Tue, 17 Sep 2024 17:39:24 +0200
Subject: [PATCH] DEV: Remove unused code from glimmer topic list (#28946)

---
 .../components/topic-list/activity-column.gjs | 52 ++++++++-----------
 .../topic-list/latest-topic-list-item.gjs     |  7 +--
 .../app/components/topic-list/list.gjs        |  2 -
 .../topic-list/topic-list-header-column.gjs   |  1 -
 .../components/topic-list/topic-list-item.gjs |  2 -
 5 files changed, 22 insertions(+), 42 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/topic-list/activity-column.gjs b/app/assets/javascripts/discourse/app/components/topic-list/activity-column.gjs
index 3f9875433b2..9b522af40ee 100644
--- a/app/assets/javascripts/discourse/app/components/topic-list/activity-column.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-list/activity-column.gjs
@@ -1,39 +1,29 @@
-import Component from "@glimmer/component";
 import { hash } from "@ember/helper";
-import { service } from "@ember/service";
 import { htmlSafe } from "@ember/template";
 import PluginOutlet from "discourse/components/plugin-outlet";
 import coldAgeClass from "discourse/helpers/cold-age-class";
 import concatClass from "discourse/helpers/concat-class";
-import element from "discourse/helpers/element";
 import formatDate from "discourse/helpers/format-date";
 
-export default class ActivityColumn extends Component {
-  @service siteSettings;
-
-  get wrapperElement() {
-    return element(this.args.tagName ?? "td");
-  }
-
-  <template>
-    <this.wrapperElement
-      title={{htmlSafe @topic.bumpedAtTitle}}
-      class={{concatClass
-        "activity"
-        (coldAgeClass @topic.createdAt startDate=@topic.bumpedAt class="")
-      }}
-      ...attributes
-    >
-      <a
-        href={{@topic.lastPostUrl}}
-        class="post-activity"
-      >{{! no whitespace
+const ActivityColumn = <template>
+  <td
+    title={{htmlSafe @topic.bumpedAtTitle}}
+    class={{concatClass
+      "activity"
+      (coldAgeClass @topic.createdAt startDate=@topic.bumpedAt class="")
+    }}
+    ...attributes
+  >
+    <a
+      href={{@topic.lastPostUrl}}
+      class="post-activity"
+    >{{! no whitespace
         }}<PluginOutlet
-          @name="topic-list-before-relative-date"
-          @outletArgs={{hash topic=@topic}}
-        />
-        {{~formatDate @topic.bumpedAt format="tiny" noTitle="true"~}}
-      </a>
-    </this.wrapperElement>
-  </template>
-}
+        @name="topic-list-before-relative-date"
+        @outletArgs={{hash topic=@topic}}
+      />
+      {{~formatDate @topic.bumpedAt format="tiny" noTitle="true"~}}
+    </a>
+  </td>
+</template>;
+export default ActivityColumn;
diff --git a/app/assets/javascripts/discourse/app/components/topic-list/latest-topic-list-item.gjs b/app/assets/javascripts/discourse/app/components/topic-list/latest-topic-list-item.gjs
index c940bd0a958..510397eb637 100644
--- a/app/assets/javascripts/discourse/app/components/topic-list/latest-topic-list-item.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-list/latest-topic-list-item.gjs
@@ -1,6 +1,5 @@
 import Component from "@glimmer/component";
 import { concat, hash } from "@ember/helper";
-import { service } from "@ember/service";
 import PluginOutlet from "discourse/components/plugin-outlet";
 import PostsCountColumn from "discourse/components/topic-list/posts-count-column";
 import TopicPostBadges from "discourse/components/topic-post-badges";
@@ -16,12 +15,8 @@ import topicFeaturedLink from "discourse/helpers/topic-featured-link";
 import topicLink from "discourse/helpers/topic-link";
 
 export default class LatestTopicListItem extends Component {
-  @service appEvents;
-
   get tagClassNames() {
-    if (this.args.topic.tags) {
-      return this.args.topic.tags.map((tagName) => `tag-${tagName}`);
-    }
+    return this.args.topic.tags?.map((tagName) => `tag-${tagName}`);
   }
 
   <template>
diff --git a/app/assets/javascripts/discourse/app/components/topic-list/list.gjs b/app/assets/javascripts/discourse/app/components/topic-list/list.gjs
index fa0ac5e52c9..1700577f82a 100644
--- a/app/assets/javascripts/discourse/app/components/topic-list/list.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-list/list.gjs
@@ -11,8 +11,6 @@ import i18n from "discourse-common/helpers/i18n";
 
 export default class TopicList extends Component {
   @service currentUser;
-  @service router;
-  @service siteSettings;
 
   @tracked lastCheckedElementId;
 
diff --git a/app/assets/javascripts/discourse/app/components/topic-list/topic-list-header-column.gjs b/app/assets/javascripts/discourse/app/components/topic-list/topic-list-header-column.gjs
index 3bdeaf02dad..41b3ef7798a 100644
--- a/app/assets/javascripts/discourse/app/components/topic-list/topic-list-header-column.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-list/topic-list-header-column.gjs
@@ -9,7 +9,6 @@ import icon from "discourse-common/helpers/d-icon";
 import i18n from "discourse-common/helpers/i18n";
 
 export default class TopicListHeaderColumn extends Component {
-  @service modal;
   @service router;
 
   get localizedName() {
diff --git a/app/assets/javascripts/discourse/app/components/topic-list/topic-list-item.gjs b/app/assets/javascripts/discourse/app/components/topic-list/topic-list-item.gjs
index d0a77f9d5be..e0591c3effc 100644
--- a/app/assets/javascripts/discourse/app/components/topic-list/topic-list-item.gjs
+++ b/app/assets/javascripts/discourse/app/components/topic-list/topic-list-item.gjs
@@ -35,11 +35,9 @@ import { bind } from "discourse-common/utils/decorators";
 import I18n from "discourse-i18n";
 
 export default class TopicListItem extends Component {
-  @service appEvents;
   @service currentUser;
   @service historyStore;
   @service messageBus;
-  @service router;
   @service site;
   @service siteSettings;