FIX: only add image size when with & height are in pixels
This commit is contained in:
parent
589351d996
commit
155cad8b85
|
@ -220,10 +220,10 @@ class InlineUploads
|
|||
|
||||
if src && (matched_uploads(src).present? || external_src)
|
||||
text = node.attributes["alt"]&.value
|
||||
width = node.attributes["width"]&.value
|
||||
height = node.attributes["height"]&.value
|
||||
width = node.attributes["width"]&.value.to_i
|
||||
height = node.attributes["height"]&.value.to_i
|
||||
title = node.attributes["title"]&.value
|
||||
text = "#{text}|#{width}x#{height}" if width && height
|
||||
text = "#{text}|#{width}x#{height}" if width > 0 && height > 0
|
||||
after_html_tag = match[0].present?
|
||||
|
||||
spaces_before =
|
||||
|
|
|
@ -267,6 +267,7 @@ RSpec.describe InlineUploads do
|
|||
#{Discourse.base_url}#{upload3.url} #{Discourse.base_url}#{upload3.url}
|
||||
|
||||
<img src="#{upload.url}" width="5" height="4">
|
||||
<img src="#{upload.url}" width="5px" height="auto">
|
||||
MD
|
||||
|
||||
expect(InlineUploads.process(md)).to eq(<<~MD)
|
||||
|
@ -283,6 +284,7 @@ RSpec.describe InlineUploads do
|
|||
#{Discourse.base_url}#{upload3.short_path} #{Discourse.base_url}#{upload3.short_path}
|
||||
|
||||
![|5x4](#{upload.short_url})
|
||||
![](#{upload.short_url})
|
||||
MD
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in New Issue