Merge pull request #5120 from LeoMcA/new-topic-redirect-loop

FIX: redirect loop for new users visiting /new-topic using full screen login

app/assets/javascripts/discourse.js.es6

@@ -8,6 +8,7 @@ const Discourse = Ember.Application.extend({
   _docTitle: document.title,
   RAW_TEMPLATES: {},
   __widget_helpers: {},
+  showingSignup: false,
 
   getURL(url) {
     if (!url) return url;

app/assets/javascripts/discourse/routes/new-message.js.es6

@@ -34,7 +34,11 @@ export default Discourse.Route.extend({
       });
     } else {
       $.cookie('destination_url', window.location.href);
-      this.replaceWith('login');
+      if (Discourse.showingSignup) {
+        Discourse.showingSignup = false;
+      } else {
+        self.replaceWith('login');
+      }
     }
   }
 

app/assets/javascripts/discourse/routes/new-topic.js.es6

@@ -14,7 +14,12 @@ export default Discourse.Route.extend({
     } else {
       // User is not logged in
       $.cookie('destination_url', window.location.href);
-      self.replaceWith('login');
+      if (Discourse.showingSignup) {
+        // We're showing the sign up modal
+        Discourse.showingSignup = false;
+      } else {
+        self.replaceWith('login');
+      }
     }
   }
 });

app/views/common/_discourse_javascript.html.erb

@@ -21,6 +21,7 @@
 
 <script>
   <%- if !current_user && flash[:authentication_data] %>
+    Discourse.showingSignup = true
     require('discourse/routes/application').default.reopen({
       actions: {
         didTransition: function() {