Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: `Ember.warn` needs an `id` 

This way errors can be customized/silenced in the console.
This commit is contained in:
Robin Ward 2019-01-16 14:53:13 -05:00
parent 98f26bcaf5
commit 16a7102dad
4 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/admin/mixins/setting-component.js.es6
View File

@ -101,7 +101,7 @@ export default Ember.Mixin.create({
_save() {
Ember.warn("You should define a `_save` method", {
id: "admin.mixins.setting-component"
id: "discourse.setting-component.missing-save"
});
return Ember.RSVP.resolve();
},

4
app/assets/javascripts/discourse-common/lib/buffered-render.js.es6
View File

@ -19,7 +19,9 @@ const Mixin = {
export function bufferedRender(obj) {
if (!obj.buildBuffer) {
Ember.warn("Missing `buildBuffer` method");
Ember.warn("Missing `buildBuffer` method", {
id: "discourse.buffered-render.missing-build-buffer"
});
return obj;
}

4
app/assets/javascripts/discourse/mixins/upload.js.es6
View File

@ -9,7 +9,9 @@ export default Ember.Mixin.create({
uploadProgress: 0,
uploadDone() {
Ember.warn("You should implement `uploadDone`");
Ember.warn("You should implement `uploadDone`", {
id: "discourse.upload.missing-upload-done"
});
},
validateUploadedFilesOptions() {

5
app/assets/javascripts/discourse/models/rest.js.es6
View File

@ -24,7 +24,9 @@ const RestModel = Ember.Object.extend({
const payload = self.__munge(res.payload || res.responseJson);
if (payload.success === "OK") {
Ember.warn("An update call should return the updated attributes");
Ember.warn("An update call should return the updated attributes", {
id: "discourse.rest-model.update-attributes"
});
res = props;
}
@ -97,7 +99,6 @@ RestModel.reopenClass({
args = args || {};
if (!args.store) {
const container = Discourse.__container__;
// Ember.warn('Use `store.createRecord` to create records instead of `.create()`');
args.store = container.lookup("service:store");
}