handle emails with localized headers 😠

lib/email/receiver.rb

@@ -239,6 +239,8 @@ module Email
     end
 
     def parse_from_field(mail)
+      return unless mail[:from]
+
       if mail[:from].errors.blank?
         mail[:from].address_list.addresses.each do |address_field|
           address_field.decoded

spec/components/email/receiver_spec.rb

@@ -383,8 +383,10 @@ describe Email::Receiver do
       expect(Post.last.raw).to match(/discourse\.rb/)
     end
 
+    context "with forwarded emails enabled" do
+      before { SiteSetting.enable_forwarded_emails = true }
+
       it "handles forwarded emails" do
-      SiteSetting.enable_forwarded_emails = true
         expect { process(:forwarded_email_1) }.to change(Topic, :count)
 
         forwarded_post, last_post = *Post.last(2)
@@ -416,6 +418,13 @@ describe Email::Receiver do
         expect(last_post.post_type).to eq(Post.types[:whisper])
       end
 
+      # Who thought this was a good idea?!
+      it "doesn't blow up with localized email headers" do
+        expect { process(:forwarded_email_3) }.to change(Topic, :count)
+      end
+
+    end
+
   end
 
   context "new topic in a category" do

spec/fixtures/emails/forwarded_email_3.eml

@@ -0,0 +1,18 @@
+Message-ID: <60@foo.bar.mail>
+From: Ba Bar <ba@bar.com>
+To: Team <team@bar.com>
+Date: Mon, 9 Dec 2016 13:37:42 +0100
+Subject: Fwd: Ça Discourse ?
+
+@team, can you have a look at this email below?
+
+Objet: Ça Discourse ?
+Date: 2017-01-04 11:27
+De: Un Français <un@francais.fr>
+À: ba@bar.com
+
+Bonjour,
+
+Ça Discourse bien aujourd'hui ?
+
+Bises