Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Replying to OP is a reply to the topic, not the post (#23380) 

Clicking on the OP's Reply button twice results in the post being a reply to post number 1. This is a fix for that.
This commit is contained in:
Natalie Tay 2023-09-04 17:06:41 +08:00 committed by GitHub
parent 7ea3079e3e
commit 187f9a9495
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/app/controllers/topic.js
View File

@ -657,7 +657,8 @@ export default Controller.extend(bufferedProperty("model"), {
if ( if (
composerController.get("model.topic.id") === topic.get("id") && composerController.get("model.topic.id") === topic.get("id") &&
composerController.get("model.action") === Composer.REPLY composerController.get("model.action") === Composer.REPLY &&
post?.get("post_number") !== 1
) { ) {
composerController.set("model.post", post); composerController.set("model.post", post);
composerController.set("model.composeState", Composer.OPEN); composerController.set("model.composeState", Composer.OPEN);

16
app/assets/javascripts/discourse/tests/acceptance/composer-test.js
View File

@ -334,6 +334,22 @@ acceptance("Composer", function (needs) {
); );
}); });
test("Replying to the first post in a topic is a topic reply", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("#post_1 .reply.create");
assert.strictEqual(
query(".reply-details a.topic-link").innerText,
"Internationalization / localization"
);
await click("#post_1 .reply.create");
assert.strictEqual(
query(".reply-details a.topic-link").innerText,
"Internationalization / localization"
);
});
test("Can edit a post after starting a reply", async function (assert) { test("Can edit a post after starting a reply", async function (assert) {
await visit("/t/internationalization-localization/280"); await visit("/t/internationalization-localization/280");