From 18c560903d1942dc7762f103ccaecc40f05ffbe0 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Tue, 14 Feb 2023 11:37:06 +0000 Subject: [PATCH] DEV: Skip failing modifyClass test (#20281) This is a known failure. Using todo causes it to show up at the bottom of all test runs, which is annoying. Let's just skip it instead. --- .../javascripts/discourse/tests/unit/lib/plugin-api-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/tests/unit/lib/plugin-api-test.js b/app/assets/javascripts/discourse/tests/unit/lib/plugin-api-test.js index 516f326b0f5..b73dc9f4cff 100644 --- a/app/assets/javascripts/discourse/tests/unit/lib/plugin-api-test.js +++ b/app/assets/javascripts/discourse/tests/unit/lib/plugin-api-test.js @@ -1,4 +1,4 @@ -import { module, test, todo } from "qunit"; +import { module, skip, test } from "qunit"; import EmberObject from "@ember/object"; import discourseComputed from "discourse-common/utils/decorators"; import { withPluginApi } from "discourse/lib/plugin-api"; @@ -88,7 +88,7 @@ module("Unit | Utility | plugin-api", function (hooks) { assert.strictEqual(thingy.prop, "g'day"); }); - todo("modifyClass works with getters", function (assert) { + skip("modifyClass works with getters", function (assert) { let Base = EmberObject.extend({ get foo() { throw new Error("base getter called");