Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Improve skip test comment (#22215) 

Why this change?

The comment consists of an output that was copied from RSpec's default
output. This has the potential to mess with systems that are parsing
RSpec's output to fetch the spec failures as those systems are usually
looking for the first occurence of `Failures:`
This commit is contained in:
Alan Guo Xiang Tan 2023-06-21 08:09:39 +08:00 committed by GitHub
parent d6f2b9c72c
commit 1987fce018
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/system/network_disconnected_spec.rb
View File

@ -6,9 +6,6 @@ RSpec.describe "Network Disconnected", type: :system do
before { skip(<<~TEXT) }
This group of tests is flaky and needs to be fixed. Example of error:
Failures:
1) Network Disconnected Doesn't show the offline indicator when the site setting isn't present
Failure/Error: expect(page).to have_css("html.message-bus-offline")
expected to find css "html.message-bus-offline" but there were no matches
TEXT