From 19c9b892dcd2f7d7c811a9925127776d4b4fb0f3 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 29 Oct 2021 03:03:22 +0200 Subject: [PATCH] DEV: Instantiate relation early to save a query (#14766) Previously it would do `SELECT 1 AS one` and then `SELECT "color_scheme_colors".*`. Now it only does the latter. --- app/models/color_scheme.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/color_scheme.rb b/app/models/color_scheme.rb index bcd7d7c02fe..afb897f9b48 100644 --- a/app/models/color_scheme.rb +++ b/app/models/color_scheme.rb @@ -346,7 +346,7 @@ class ColorScheme < ActiveRecord::Base end def is_dark? - return if colors.empty? + return if colors.to_a.empty? primary_b = brightness(colors_by_name["primary"].hex) secondary_b = brightness(colors_by_name["secondary"].hex)