Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Minor cleanup of create-account tests (#14989)

This commit is contained in:
Jarek Radosz 2021-11-24 16:43:25 +01:00 committed by GitHub
parent 8c7cc426b7
commit 1ab4b1a4a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/controllers/create-account.js
View File

@ -295,6 +295,10 @@ export default Controller.extend(
this._hpPromise = ajax("/session/hp.json")
.then((json) => {
if (this.isDestroying || this.isDestroyed) {
return;
}
this._challengeDate = new Date();
// remove 30 seconds for jitter, make sure this works for at least
// 30 seconds so we don't have hard loops

21
app/assets/javascripts/discourse/tests/unit/controllers/create-account-test.js
View File

@ -3,8 +3,8 @@ import { discourseModule } from "discourse/tests/helpers/qunit-helpers";
import { test } from "qunit";
discourseModule("Unit | Controller | create-account", function () {
test("basicUsernameValidation", async function (assert) {
const testInvalidUsername = async (username, expectedReason) => {
test("basicUsernameValidation", function (assert) {
const testInvalidUsername = (username, expectedReason) => {
const controller = this.getController("create-account");
controller.set("accountUsername", username);
@ -24,8 +24,7 @@ discourseModule("Unit | Controller | create-account", function () {
I18n.t("user.username.too_long")
);
const controller = await this.owner.lookup("controller:create-account");
controller.setProperties({
const controller = this.getController("create-account", {
accountUsername: "porkchops",
prefilledUsername: "porkchops",
});
@ -39,7 +38,7 @@ discourseModule("Unit | Controller | create-account", function () {
);
});
test("passwordValidation", async function (assert) {
test("passwordValidation", function (assert) {
const controller = this.getController("create-account");
controller.set("authProvider", "");
@ -49,12 +48,12 @@ discourseModule("Unit | Controller | create-account", function () {
controller.set("accountPassword", "b4fcdae11f9167");
assert.strictEqual(
controller.get("passwordValidation.ok"),
controller.passwordValidation.ok,
true,
"Password is ok"
);
assert.strictEqual(
controller.get("passwordValidation.reason"),
controller.passwordValidation.reason,
I18n.t("user.password.ok"),
"Password is valid"
);
@ -63,12 +62,12 @@ discourseModule("Unit | Controller | create-account", function () {
controller.set("accountPassword", password);
assert.strictEqual(
controller.get("passwordValidation.failed"),
controller.passwordValidation.failed,
true,
"password should be invalid: " + password
);
assert.strictEqual(
controller.get("passwordValidation.reason"),
controller.passwordValidation.reason,
expectedReason,
"password validation reason: " + password + ", " + expectedReason
);
@ -83,8 +82,8 @@ discourseModule("Unit | Controller | create-account", function () {
);
});
test("authProviderDisplayName", async function (assert) {
const controller = this.owner.lookup("controller:create-account");
test("authProviderDisplayName", function (assert) {
const controller = this.getController("create-account");
assert.strictEqual(
controller.authProviderDisplayName("facebook"),