Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Use id instead of elementId in hbs file 

I think this issue is caused by a current regression in ember

https://github.com/emberjs/ember.js/issues/18147

but using `id` works just fine in templates. This also appears to be the
only template file we are using `elementId` directly in the template.
This commit is contained in:
Blake Erickson 2020-03-18 13:38:21 -06:00
parent 1393950dbc
commit 1c7680c568
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/templates/modal/move-to-topic.hbs
View File

@ -20,7 +20,7 @@
<p>{{html-safe (i18n 'topic.move_to_new_message.instructions' count=selectedPostsCount)}}</p> <p>{{html-safe (i18n 'topic.move_to_new_message.instructions' count=selectedPostsCount)}}</p>
<form> <form>
<label>{{i18n 'topic.move_to_new_message.message_title'}}</label> <label>{{i18n 'topic.move_to_new_message.message_title'}}</label>
{{text-field value=topicName placeholderKey="composer.title_placeholder" elementId='split-topic-name'}} {{text-field value=topicName placeholderKey="composer.title_placeholder" id='split-topic-name'}}
{{#if canTagMessages}} {{#if canTagMessages}}
<label>{{i18n 'tagging.tags'}}</label> <label>{{i18n 'tagging.tags'}}</label>
@ -75,7 +75,7 @@
<p>{{html-safe (i18n 'topic.split_topic.instructions' count=selectedPostsCount)}}</p> <p>{{html-safe (i18n 'topic.split_topic.instructions' count=selectedPostsCount)}}</p>
<form> <form>
<label>{{i18n 'topic.split_topic.topic_name'}}</label> <label>{{i18n 'topic.split_topic.topic_name'}}</label>
{{text-field value=topicName placeholderKey="composer.title_placeholder" elementId='split-topic-name'}} {{text-field value=topicName placeholderKey="composer.title_placeholder" id='split-topic-name'}}
<label>{{i18n 'categories.category'}}</label> <label>{{i18n 'categories.category'}}</label>
{{category-chooser {{category-chooser
@ -96,7 +96,7 @@
<p>{{html-safe (i18n 'topic.move_to_new_message.instructions' count=selectedPostsCount)}}</p> <p>{{html-safe (i18n 'topic.move_to_new_message.instructions' count=selectedPostsCount)}}</p>
<form> <form>
<label>{{i18n 'topic.move_to_new_message.message_title'}}</label> <label>{{i18n 'topic.move_to_new_message.message_title'}}</label>
{{text-field value=topicName placeholderKey="composer.title_placeholder" elementId='split-topic-name'}} {{text-field value=topicName placeholderKey="composer.title_placeholder" id='split-topic-name'}}
{{#if canTagMessages}} {{#if canTagMessages}}
<label>{{i18n 'tagging.tags'}}</label> <label>{{i18n 'tagging.tags'}}</label>