Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Restore qunit 'tap' reporter, but collapse verbose output in CI (#26484) 

This reverts commit 5adfb299ac, but uses GitHub actions grouping to achieve the same result: less scrolling to see failures.
This commit is contained in:
David Taylor 2024-04-03 10:22:20 +01:00 committed by GitHub
parent b38750d3be
commit 1e42e86601
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/tests.yml vendored
View File

@ -220,12 +220,12 @@ jobs:
- name: Plugin QUnit
if: matrix.build_type == 'frontend' && matrix.target == 'plugins'
run: QUNIT_REPORTER_FORMAT=dot QUNIT_WRITE_EXECUTION_FILE=1 QUNIT_PARALLEL=3 bin/rake plugin:qunit['*','1200000']
run: QUNIT_WRITE_EXECUTION_FILE=1 QUNIT_PARALLEL=3 bin/rake plugin:qunit['*','1200000']
timeout-minutes: 30
- name: Theme QUnit
if: matrix.build_type == 'frontend' && matrix.target == 'themes'
run: QUNIT_REPORTER_FORMAT=dot DISCOURSE_DEV_DB=discourse_test QUNIT_PARALLEL=3 bin/rake themes:qunit_all_official
run: DISCOURSE_DEV_DB=discourse_test QUNIT_PARALLEL=3 bin/rake themes:qunit_all_official
timeout-minutes: 15
- uses: actions/upload-artifact@v4
@ -389,7 +389,7 @@ jobs:
- name: Core QUnit
working-directory: ./app/assets/javascripts/discourse
run: yarn ember exam --path /tmp/emberbuild --load-balance --parallel=5 --reporter=dot --launch "${{ env.TESTEM_BROWSER }}" --write-execution-file --random
run: yarn ember exam --path /tmp/emberbuild --load-balance --parallel=5 --launch "${{ env.TESTEM_BROWSER }}" --write-execution-file --random
timeout-minutes: 15
- uses: actions/upload-artifact@v4

8
app/assets/javascripts/discourse/testem.js
View File

@ -15,6 +15,10 @@ class Reporter extends TapReporter {
if (process.env.GITHUB_ACTIONS) {
colors.enable();
}
if (process.env.GITHUB_ACTIONS) {
this.out.write("::group:: Verbose QUnit test output\n");
}
}
reportMetadata(tag, metadata) {
@ -105,6 +109,10 @@ class Reporter extends TapReporter {
}
finish() {
if (process.env.GITHUB_ACTIONS) {
this.out.write("::endgroup::");
}
super.finish();
this.reportDeprecations();

1
lib/tasks/qunit.rake
View File

@ -132,7 +132,6 @@ task "qunit:test", %i[timeout qunit_path filter] do |_, args|
cmd += ["--load-balance", "--parallel", parallel] if parallel
cmd += ["--filter", filter] if filter
cmd << "--write-execution-file" if ENV["QUNIT_WRITE_EXECUTION_FILE"]
cmd << "--reporter=#{ENV["QUNIT_REPORTER_FORMAT"]}" if ENV["QUNIT_REPORTER_FORMAT"]
end
# Print out all env for debugging purposes