From 1f17602b86e513e0763f3699a98c8ee6c8d7956c Mon Sep 17 00:00:00 2001
From: Jarek Radosz <jradosz@gmail.com>
Date: Tue, 19 Mar 2024 23:59:37 +0100
Subject: [PATCH] DEV: Remove href/auto-route attrs from buttons (#26247)

Those apply only to `a` elements
---
 .../discourse/app/components/glimmer-header/dropdown.gjs      | 2 --
 .../discourse/app/components/glimmer-header/user-dropdown.gjs | 2 --
 app/assets/javascripts/discourse/app/widgets/header.js        | 4 ----
 3 files changed, 8 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/glimmer-header/dropdown.gjs b/app/assets/javascripts/discourse/app/components/glimmer-header/dropdown.gjs
index 2069a0e4d72..bdfc0d1da87 100644
--- a/app/assets/javascripts/discourse/app/components/glimmer-header/dropdown.gjs
+++ b/app/assets/javascripts/discourse/app/components/glimmer-header/dropdown.gjs
@@ -42,8 +42,6 @@ export default class Dropdown extends Component {
         class="button icon btn-flat"
         aria-expanded={{@active}}
         aria-haspopup="true"
-        href={{@href}}
-        data-auto-route="true"
         title={{i18n @title}}
         aria-label={{i18n @title}}
         id={{@iconId}}
diff --git a/app/assets/javascripts/discourse/app/components/glimmer-header/user-dropdown.gjs b/app/assets/javascripts/discourse/app/components/glimmer-header/user-dropdown.gjs
index 17459540234..3b1ad01a0a8 100644
--- a/app/assets/javascripts/discourse/app/components/glimmer-header/user-dropdown.gjs
+++ b/app/assets/javascripts/discourse/app/components/glimmer-header/user-dropdown.gjs
@@ -37,12 +37,10 @@ export default class UserDropdown extends Component {
         class="icon btn-flat"
         aria-haspopup="true"
         aria-expanded={{@active}}
-        href={{this.currentUser.path}}
         aria-label={{i18n
           "user.account_possessive"
           name=(or this.currentUser.name this.currentUser.username)
         }}
-        data-auto-route="true"
         {{on "click" this.click}}
       >
         <Notifications @active={{@active}} />
diff --git a/app/assets/javascripts/discourse/app/widgets/header.js b/app/assets/javascripts/discourse/app/widgets/header.js
index 4fa00a3b950..1fb79609c9e 100644
--- a/app/assets/javascripts/discourse/app/widgets/header.js
+++ b/app/assets/javascripts/discourse/app/widgets/header.js
@@ -187,11 +187,9 @@ createWidget(
             attributes: {
               "aria-haspopup": true,
               "aria-expanded": attrs.active,
-              href: attrs.user.path,
               "aria-label": I18n.t("user.account_possessive", {
                 name: attrs.user.name || attrs.user.username,
               }),
-              "data-auto-route": true,
             },
           },
           this.attach("header-notifications", attrs)
@@ -222,8 +220,6 @@ createWidget(
             attributes: {
               "aria-expanded": attrs.active,
               "aria-haspopup": true,
-              href: attrs.href,
-              "data-auto-route": true,
               title,
               "aria-label": title,
               id: attrs.iconId,