Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: Move `where` clause up to speed up CalculateAvgTime daily job (#7462) 

Cuts down affected posts earlier in the query, so the generated plan
deals with less rows, and runs faster.

https://meta.discourse.org/t/post-calculate-avg-time-taking-up-a-long-time/49750/13?u=falco
This commit is contained in:
Rafael dos Santos Silva 2019-04-30 00:34:46 -03:00 committed by Sam
parent dca7f8ecf2
commit 1fdeec564b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/post.rb
View File

@ -688,6 +688,7 @@ class Post < ActiveRecord::Base
ON p2.post_number = post_timings.post_number ON p2.post_number = post_timings.post_number
AND p2.topic_id = post_timings.topic_id AND p2.topic_id = post_timings.topic_id
AND p2.user_id <> post_timings.user_id AND p2.user_id <> post_timings.user_id
/*where2*/
GROUP BY post_timings.topic_id, post_timings.post_number) AS x GROUP BY post_timings.topic_id, post_timings.post_number) AS x
/*where*/") /*where*/")
@ -696,7 +697,7 @@ class Post < ActiveRecord::Base
AND (posts.avg_time <> (x.gmean / 1000)::int OR posts.avg_time IS NULL)") AND (posts.avg_time <> (x.gmean / 1000)::int OR posts.avg_time IS NULL)")
if min_topic_age if min_topic_age
builder.where("posts.topic_id IN (SELECT id FROM topics where bumped_at > :bumped_at)", builder.where2("p2.topic_id IN (SELECT id FROM topics where bumped_at > :bumped_at)",
bumped_at: min_topic_age) bumped_at: min_topic_age)
end end