Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove temporary GlimmerComponent hack (#17370) 

fc36ac6c updated us to a more modern resolver, so this hack is no longer required
This commit is contained in:
David Taylor 2022-07-07 15:08:46 +01:00 committed by GitHub
parent ef923f1bb1
commit 201228162c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/javascripts/discourse/app/components/glimmer.js
View File

@ -2,7 +2,6 @@ import GlimmerComponent from "@glimmer/component";
import { cached } from "@glimmer/tracking"; import { cached } from "@glimmer/tracking";
import { getOwner } from "@ember/application"; import { getOwner } from "@ember/application";
import { inject as service } from "@ember/service"; import { inject as service } from "@ember/service";
import { DEBUG } from "@glimmer/env";
/* /*
Glimmer components are not EmberObjects, and therefore do not support automatic Glimmer components are not EmberObjects, and therefore do not support automatic
@ -71,11 +70,3 @@ export default class DiscourseGlimmerComponent extends GlimmerComponent {
return applicationInstance.lookup("key-value-store:main"); return applicationInstance.lookup("key-value-store:main");
} }
} }
// This little hack will trick our outdated Ember GlobalResolver into
// accepting glimmer components in debug mode.
// https://github.com/emberjs/ember.js/blob/d4dc4b4cc5/packages/%40ember/application/globals-resolver.js#L142-L165
// We can remove it once we've updated our resolver to a more recent implementation
if (DEBUG) {
DiscourseGlimmerComponent.isComponentFactory = true;
}