From 2167d4d8907413ba2475ff0a1cacb1c58a98f75b Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Tue, 16 Nov 2021 12:19:14 +0100 Subject: [PATCH] FIX: fix regressions introduced in ae16b0a (#14967) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - ensures arrow up/down doesn’t also apply to textarea while autocomplete is opened - ensures esc is closing autocomplete and also not closing composer while autocomplete is opened --- app/assets/javascripts/discourse/app/lib/autocomplete.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/assets/javascripts/discourse/app/lib/autocomplete.js b/app/assets/javascripts/discourse/app/lib/autocomplete.js index 30d4aa519de..56450508780 100644 --- a/app/assets/javascripts/discourse/app/lib/autocomplete.js +++ b/app/assets/javascripts/discourse/app/lib/autocomplete.js @@ -558,6 +558,8 @@ export default function (options) { if (e.which === keys.esc) { if (div !== null) { closeAutocomplete(); + e.preventDefault(); + e.stopImmediatePropagation(); return false; } return true; @@ -605,6 +607,7 @@ export default function (options) { selectedOption = 0; } markSelected(); + e.preventDefault(); return false; case keys.downArrow: total = autocompleteOptions.length; @@ -616,6 +619,7 @@ export default function (options) { selectedOption = 0; } markSelected(); + e.preventDefault(); return false; case keys.backSpace: autocompleteOptions = null;