FIX: Use user account email instead of auth email when totp is enabled.

https://meta.discourse.org/t/github-2fa-flow-broken/88674

app/controllers/users/omniauth_callbacks_controller.rb

@@ -120,6 +120,7 @@ class Users::OmniauthCallbacksController < ApplicationController
   def user_found(user)
     if user.totp_enabled?
       @auth_result.omniauth_disallow_totp = true
+      @auth_result.email = user.email
       return
     end
 

spec/requests/omniauth_callbacks_controller_spec.rb

@@ -140,12 +140,18 @@ RSpec.describe Users::OmniauthCallbacksController do
         it 'should return the right response' do
           get "/auth/google_oauth2/callback.json"
 
-          expect(response).to be_success
+          expect(response.status).to eq(200)
 
           response_body = JSON.parse(response.body)
 
           expect(response_body["email"]).to eq(user.email)
           expect(response_body["omniauth_disallow_totp"]).to eq(true)
+
+          user.update!(email: 'different@user.email')
+          get "/auth/google_oauth2/callback.json"
+
+          expect(response.status).to eq(200)
+          expect(JSON.parse(response.body)["email"]).to eq(user.email)
         end
       end