Tests are still leaking connection after skipping.

* Could be in the setup.
This commit is contained in:
Guo Xiang Tan 2017-12-04 10:46:30 +08:00
parent e73fbfe265
commit 22140efa70
1 changed files with 3 additions and 4 deletions

View File

@ -27,6 +27,7 @@ describe ActiveRecord::ConnectionHandling do
let(:postgresql_fallback_handler) { PostgreSQLFallbackHandler.instance } let(:postgresql_fallback_handler) { PostgreSQLFallbackHandler.instance }
before do before do
skip("Figure out why this test leaks connections")
postgresql_fallback_handler.initialized = true postgresql_fallback_handler.initialized = true
['default', multisite_db].each do |db| ['default', multisite_db].each do |db|
@ -41,8 +42,6 @@ describe ActiveRecord::ConnectionHandling do
describe "#postgresql_fallback_connection" do describe "#postgresql_fallback_connection" do
it 'should return a PostgreSQL adapter' do it 'should return a PostgreSQL adapter' do
skip("Figure out why this test leaks connections")
begin begin
connection = ActiveRecord::Base.postgresql_fallback_connection(config) connection = ActiveRecord::Base.postgresql_fallback_connection(config)
@ -55,7 +54,7 @@ describe ActiveRecord::ConnectionHandling do
context 'when master server is down' do context 'when master server is down' do
before do before do
skip("Figure out why this test leaks connections")
@replica_connection = mock('replica_connection') @replica_connection = mock('replica_connection')
end end
@ -154,7 +153,7 @@ describe ActiveRecord::ConnectionHandling do
describe '.verify_replica' do describe '.verify_replica' do
describe 'when database is not in recovery' do describe 'when database is not in recovery' do
it 'should raise the right error' do it 'should raise the right error' do
skip("Figure out why this test leaks connections")
expect do expect do
ActiveRecord::Base.send(:verify_replica, ActiveRecord::Base.connection) ActiveRecord::Base.send(:verify_replica, ActiveRecord::Base.connection)