DEV: Fix "no-setter-return" lint (#24585)

app/assets/javascripts/admin/addon/components/admin-theme-editor.js

@@ -69,7 +69,6 @@ export default class AdminThemeEditor extends Component {
 
   set activeSection(value) {
     this.theme.setField(this.currentTargetName, this.fieldName, value);
-    return value;
   }
 
   @discourseComputed("maximized")

app/assets/javascripts/admin/addon/components/email-styles-editor.js

@@ -30,7 +30,6 @@ export default class EmailStylesEditor extends Component {
 
   set editorContents(value) {
     this.styles.setField(this.fieldName, value);
-    return value;
   }
 
   @action

app/assets/javascripts/admin/addon/components/embedding-setting.js

@@ -28,6 +28,5 @@ export default class EmbeddingSetting extends Component {
 
   set checked(value) {
     this.set("value", value);
-    return value;
   }
 }

app/assets/javascripts/admin/addon/components/site-settings/bool.js

@@ -13,6 +13,5 @@ export default class Bool extends Component {
 
   set enabled(value) {
     this.set("value", value ? "true" : "false");
-    return value;
   }
 }

app/assets/javascripts/admin/addon/components/webhook-event-chooser.js

@@ -23,7 +23,7 @@ export default class WebhookEventChooser extends Component {
 
     // add an association when not exists
     if (value === this.eventTypeExists) {
-      return value;
+      return;
     }
 
     if (value) {
@@ -33,7 +33,5 @@ export default class WebhookEventChooser extends Component {
         eventTypes.filter((eventType) => eventType.name === this.args.type.name)
       );
     }
-
-    return value;
   }
 }

app/assets/javascripts/admin/addon/models/api-key.js

@@ -19,7 +19,6 @@ export default class ApiKey extends RestModel {
     } else {
       this.set("_user", value);
     }
-    return this._user;
   }
 
   @discourseComputed("description")

app/assets/javascripts/discourse/app/models/topic.js

@@ -198,7 +198,7 @@ const Topic = RestModel.extend({
   },
 
   set details(value) {
-    return (this._details = value);
+    this._details = value;
   },
 
   @discourseComputed("visible")

app/assets/javascripts/discourse/app/services/composer.js

@@ -160,7 +160,7 @@ export default class ComposerService extends Service {
   }
 
   set disableSubmit(value) {
-    return this.set("_disableSubmit", value);
+    this.set("_disableSubmit", value);
   }
 
   @computed("model.category", "skipFormTemplate")
@@ -188,7 +188,7 @@ export default class ComposerService extends Service {
   }
 
   set formTemplateInitialValues(values) {
-    return this.set("_formTemplateInitialValues", values);
+    this.set("_formTemplateInitialValues", values);
   }
 
   @action
@@ -265,7 +265,6 @@ export default class ComposerService extends Service {
       key: "toolbar-enabled",
       value: val ? "true" : "false",
     });
-    return val;
   }
 
   @discourseComputed("model.canEditTitle", "model.creatingPrivateMessage")

plugins/chat/assets/javascripts/discourse/models/chat-message.js

@@ -134,7 +134,6 @@ export default class ChatMessage {
   set deletedAt(value) {
     this._deletedAt = value;
     this.incrementVersion();
-    return this._deletedAt;
   }
 
   get cooked() {