REFACTOR: Use Ember modules for @ember/service

app/assets/javascripts/admin/controllers/admin-user-index.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 import { ajax } from "discourse/lib/ajax";
 import CanCheckEmails from "discourse/mixins/can-check-emails";
@@ -8,7 +9,7 @@ import { default as computed } from "ember-addons/ember-computed-decorators";
 import { fmt } from "discourse/lib/computed";
 
 export default Controller.extend(CanCheckEmails, {
-  adminTools: Ember.inject.service(),
+  adminTools: service(),
   originalPrimaryGroupId: null,
   customGroupIdsBuffer: null,
   availableGroups: null,

app/assets/javascripts/admin/controllers/admin.js.es6

@@ -1,8 +1,9 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 import computed from "ember-addons/ember-computed-decorators";
 
 export default Controller.extend({
-  router: Ember.inject.service(),
+  router: service(),
 
   @computed("siteSettings.enable_group_directory")
   showGroups(enableGroupDirectory) {

app/assets/javascripts/admin/services/admin-tools.js.es6

@@ -7,8 +7,9 @@ import { iconHTML } from "discourse-common/lib/icon-library";
 import { ajax } from "discourse/lib/ajax";
 import showModal from "discourse/lib/show-modal";
 import { getOwner } from "discourse-common/lib/get-owner";
+import Service from "@ember/service";
 
-export default Ember.Service.extend({
+export default Service.extend({
   init() {
     this._super(...arguments);
 

app/assets/javascripts/discourse-loader.js

@@ -12,7 +12,11 @@ var define, requirejs;
         inject: Ember.inject.controller
       },
       "@ember/object": { default: Ember.Object },
-      "@ember/routing/route": { default: Ember.Route }
+      "@ember/routing/route": { default: Ember.Route },
+      "@ember/service": {
+        default: Ember.Service,
+        inject: Ember.inject.service
+      }
     };
   }
 

app/assets/javascripts/discourse/components/d-editor.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import Component from "@ember/component";
 /*global Mousetrap:true */
 import {
@@ -219,7 +220,7 @@ export default Component.extend({
   _mouseTrap: null,
   showLink: true,
   emojiPickerIsActive: false,
-  emojiStore: Ember.inject.service("emoji-store"),
+  emojiStore: service("emoji-store"),
 
   @computed("placeholder")
   placeholderTranslated(placeholder) {

app/assets/javascripts/discourse/components/d-navigation.js.es6

@@ -1,8 +1,9 @@
+import { inject as service } from '@ember/service';
 import Component from "@ember/component";
 import computed from "ember-addons/ember-computed-decorators";
 
 export default Component.extend({
-  router: Ember.inject.service(),
+  router: service(),
   persistedQueryParams: null,
 
   tagName: "",

app/assets/javascripts/discourse/components/emoji-picker.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import Component from "@ember/component";
 import { on, observes } from "ember-addons/ember-computed-decorators";
 import { findRawTemplate } from "discourse/lib/raw-templates";
@@ -18,7 +19,7 @@ const customEmojis = _.keys(extendedEmojiList()).map(code => {
 
 export default Component.extend({
   automaticPositioning: true,
-  emojiStore: Ember.inject.service("emoji-store"),
+  emojiStore: service("emoji-store"),
 
   close() {
     this._unbindEvents();

app/assets/javascripts/discourse/components/nav-item.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import Component from "@ember/component";
 /* You might be looking for navigation-item. */
 import { iconHTML } from "discourse-common/lib/icon-library";
@@ -6,7 +7,7 @@ import computed from "ember-addons/ember-computed-decorators";
 export default Component.extend({
   tagName: "li",
   classNameBindings: ["active"],
-  router: Ember.inject.service(),
+  router: service(),
 
   @computed("label", "i18nLabel", "icon")
   contents(label, i18nLabel, icon) {

app/assets/javascripts/discourse/controllers/application.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 import computed from "ember-addons/ember-computed-decorators";
 import { isAppWebview, isiOSPWA } from "discourse/lib/utilities";
@@ -5,7 +6,7 @@ import { isAppWebview, isiOSPWA } from "discourse/lib/utilities";
 export default Controller.extend({
   showTop: true,
   showFooter: false,
-  router: Ember.inject.service(),
+  router: service(),
 
   @computed
   canSignUp() {

app/assets/javascripts/discourse/controllers/composer.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import { inject } from '@ember/controller';
 import Controller from "@ember/controller";
 import DiscourseURL from "discourse/lib/url";
@@ -78,7 +79,7 @@ export function addPopupMenuOptionsCallback(callback) {
 
 export default Controller.extend({
   topicController: inject("topic"),
-  router: Ember.inject.service(),
+  router: service(),
 
   checkedMessages: false,
   messageCount: null,

app/assets/javascripts/discourse/controllers/group-activity.js.es6

@@ -1,5 +1,6 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 export default Controller.extend({
-  router: Ember.inject.service(),
+  router: service(),
   queryParams: ["category_id"]
 });

app/assets/javascripts/discourse/controllers/group-manage.js.es6

@@ -1,8 +1,9 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 import { default as computed } from "ember-addons/ember-computed-decorators";
 
 export default Controller.extend({
-  router: Ember.inject.service(),
+  router: service(),
 
   @computed("model.automatic")
   tabs(automatic) {

app/assets/javascripts/discourse/controllers/group-messages.js.es6

@@ -1,4 +1,5 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 export default Controller.extend({
-  router: Ember.inject.service()
+  router: service()
 });

app/assets/javascripts/discourse/controllers/preferences.js.es6

@@ -1,4 +1,5 @@
+import { inject as service } from '@ember/service';
 import Controller from "@ember/controller";
 export default Controller.extend({
-  router: Ember.inject.service()
+  router: service()
 });

app/assets/javascripts/discourse/controllers/user-activity.js.es6

@@ -1,10 +1,11 @@
+import { inject as service } from '@ember/service';
 import { inject } from '@ember/controller';
 import Controller from "@ember/controller";
 import { exportUserArchive } from "discourse/lib/export-csv";
 
 export default Controller.extend({
   application: inject(),
-  router: Ember.inject.service(),
+  router: service(),
   user: inject(),
   userActionType: null,
 

app/assets/javascripts/discourse/controllers/user-card.js.es6

@@ -1,4 +1,5 @@
-import { inject } from '@ember/controller';
+import { inject as service } from "@ember/service";
+import { inject } from "@ember/controller";
 import Controller from "@ember/controller";
 import {
   default as DiscourseURL,
@@ -8,7 +9,7 @@ import {
 
 export default Controller.extend({
   topic: inject(),
-  router: Ember.inject.service(),
+  router: service(),
 
   actions: {
     togglePosts(user) {

app/assets/javascripts/discourse/controllers/user-private-messages.js.es6

@@ -1,10 +1,11 @@
+import { inject as service } from '@ember/service';
 import { inject } from '@ember/controller';
 import Controller from "@ember/controller";
 import computed from "ember-addons/ember-computed-decorators";
 import Topic from "discourse/models/topic";
 
 export default Controller.extend({
-  router: Ember.inject.service(),
+  router: service(),
   userTopicsList: inject("user-topics-list"),
   user: inject(),
 

app/assets/javascripts/discourse/controllers/user.js.es6

@@ -1,3 +1,4 @@
+import { inject as service } from '@ember/service';
 import { inject } from '@ember/controller';
 import Controller from "@ember/controller";
 import CanCheckEmails from "discourse/mixins/can-check-emails";
@@ -8,7 +9,7 @@ import { prioritizeNameInUx } from "discourse/lib/settings";
 
 export default Controller.extend(CanCheckEmails, {
   indexStream: false,
-  router: Ember.inject.service(),
+  router: service(),
   userNotifications: inject("user-notifications"),
   currentPath: Ember.computed.alias("router._router.currentPath"),
   adminTools: optionalService(),

app/assets/javascripts/discourse/services/app-events.js.es6

@@ -1,6 +1,7 @@
 import deprecated from "discourse-common/lib/deprecated";
+import Service from "@ember/service";
 
-export default Ember.Service.extend(Ember.Evented, {
+export default Service.extend(Ember.Evented, {
   _events: {},
 
   on() {

app/assets/javascripts/discourse/services/emoji-store.js.es6

@@ -1,11 +1,12 @@
 import KeyValueStore from "discourse/lib/key-value-store";
+import Service from "@ember/service";
 
 const EMOJI_USAGE = "emojiUsage";
 const EMOJI_SELECTED_DIVERSITY = "emojiSelectedDiversity";
 const TRACKED_EMOJIS = 15;
 const STORE_NAMESPACE = "discourse_emojis_";
 
-export default Ember.Service.extend({
+export default Service.extend({
   init() {
     this._super(...arguments);
 

app/assets/javascripts/discourse/services/theme-settings.js.es6

@@ -1,4 +1,6 @@
-export default Ember.Service.extend({
+import Service from "@ember/service";
+
+export default Service.extend({
   settings: null,
 
   init() {