Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't grant multiple_grant badges multiple times for the same post.

This commit is contained in:
Vikhyat Korrapati 2014-06-28 00:32:09 +05:30
parent b6226ab339
commit 23983efeea
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/services/badge_granter.rb
View File

@ -15,7 +15,7 @@ class BadgeGranter
user_badge = UserBadge.find_by(badge_id: @badge.id, user_id: @user.id, post_id: @post_id)
if user_badge.nil? || @badge.multiple_grant?
if user_badge.nil? || (@badge.multiple_grant? && @post_id.nil?)
UserBadge.transaction do
user_badge = UserBadge.create!(badge: @badge, user: @user,
granted_by: @granted_by,

2
spec/services/badge_granter_spec.rb
View File

@ -90,7 +90,9 @@ describe BadgeGranter do
# Nice post badge
post.update_attributes like_count: 10
BadgeGranter.update_badges(action: :post_like, post_id: post.id)
BadgeGranter.update_badges(action: :post_like, post_id: post.id)
UserBadge.find_by(user_id: user.id, badge_id: 6).should_not be_nil
UserBadge.where(user_id: user.id, badge_id: 6).count.should == 1
# Good post badge
post.update_attributes like_count: 25
BadgeGranter.update_badges(action: :post_like, post_id: post.id)