From 23a74ecf8fb2c142c9c1d79a1c0b4f069b8c02be Mon Sep 17 00:00:00 2001
From: Bianca Nenciu <nbianca@users.noreply.github.com>
Date: Mon, 30 Jan 2023 10:49:08 +0200
Subject: [PATCH] FIX: Truncate existing user status to 100 chars (#20044)

This commits adds a database migration to limit the user status to 100
characters, limits the user status in the UI and makes sure that the
emoji is valid.

Follow up to commit b6f75e231cb49455908c980e0549290828c2162f.
---
 .../app/templates/components/user-status-picker.hbs  |  1 +
 app/models/user_status.rb                            |  2 +-
 ...7173249_truncate_user_status_to_100_characters.rb | 12 ++++++++++++
 spec/requests/user_status_controller_spec.rb         |  8 ++++++--
 spec/requests/users_controller_spec.rb               |  2 +-
 5 files changed, 21 insertions(+), 4 deletions(-)
 create mode 100644 db/migrate/20230127173249_truncate_user_status_to_100_characters.rb

diff --git a/app/assets/javascripts/discourse/app/templates/components/user-status-picker.hbs b/app/assets/javascripts/discourse/app/templates/components/user-status-picker.hbs
index fa11de21f53..9c8a5ecc264 100644
--- a/app/assets/javascripts/discourse/app/templates/components/user-status-picker.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/user-status-picker.hbs
@@ -19,6 +19,7 @@
     <Input
       class="user-status-description"
       @value={{@status.description}}
+      maxlength="100"
       placeholder={{i18n "user_status.what_are_you_doing"}}
       {{on "input" this.setDefaultEmoji}}
       {{on "focus" this.focus}}
diff --git a/app/models/user_status.rb b/app/models/user_status.rb
index fea716017d7..d163119ad70 100644
--- a/app/models/user_status.rb
+++ b/app/models/user_status.rb
@@ -15,7 +15,7 @@ class UserStatus < ActiveRecord::Base
   end
 
   def emoji_exists
-    emoji && Emoji.exists?(emoji)
+    errors.add(:emoji, :invalid) if emoji && !Emoji.exists?(emoji)
   end
 
   def ends_at_greater_than_set_at
diff --git a/db/migrate/20230127173249_truncate_user_status_to_100_characters.rb b/db/migrate/20230127173249_truncate_user_status_to_100_characters.rb
new file mode 100644
index 00000000000..36ac3eca0b8
--- /dev/null
+++ b/db/migrate/20230127173249_truncate_user_status_to_100_characters.rb
@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class TruncateUserStatusTo100Characters < ActiveRecord::Migration[7.0]
+  def up
+    execute "UPDATE user_statuses SET description = left(description, 100)"
+    execute "UPDATE user_statuses SET emoji = left(emoji, 100)"
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end
diff --git a/spec/requests/user_status_controller_spec.rb b/spec/requests/user_status_controller_spec.rb
index baa2a839185..6b25b092ffe 100644
--- a/spec/requests/user_status_controller_spec.rb
+++ b/spec/requests/user_status_controller_spec.rb
@@ -76,8 +76,12 @@ RSpec.describe UserStatusController do
       end
 
       it "validates emoji" do
-        put "/user-status.json", params: { description: "invalid_emoji_name" }
-        expect(response.status).to eq(400)
+        put "/user-status.json",
+            params: {
+              emoji: "invalid_emoji_name",
+              description: "off to dentist",
+            }
+        expect(response.status).to eq(422)
       end
 
       it "limits description’s length" do
diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rb
index 011e479eea0..a86dd23089e 100644
--- a/spec/requests/users_controller_spec.rb
+++ b/spec/requests/users_controller_spec.rb
@@ -2871,7 +2871,7 @@ RSpec.describe UsersController do
         end
 
         it "doesn't clear user status if it wasn't sent in the payload" do
-          new_status = { emoji: "off to dentist", description: "tooth" }
+          new_status = { emoji: "tooth", description: "off to dentist" }
           user.set_status!(new_status[:description], new_status[:emoji])
           user.reload