UX: change twitter share link to X (#29056)

app/assets/javascripts/discourse/app/instance-initializers/sharing-sources.js

@@ -7,10 +7,10 @@ export default {
 
     Sharing.addSource({
       id: "twitter",
-      icon: "fab-twitter",
+      icon: "fab-x-twitter",
       generateUrl(link, title, quote = "") {
         const text = quote ? `"${quote}" -- ` : title;
-        return `http://twitter.com/intent/tweet?url=${encodeURIComponent(
+        return `http://x.com/intent/tweet?url=${encodeURIComponent(
           link
         )}&text=${encodeURIComponent(text)}`;
       },

config/locales/client.en.yml

@@ -157,7 +157,7 @@ en:
       topic_html: 'Topic: <span class="topic-title">%{topicTitle}</span>'
       post: "post #%{postNumber} by @%{username}"
       close: "close"
-      twitter: "Share on Twitter"
+      twitter: "Share on X"
       facebook: "Share on Facebook"
       email: "Send via email"
       url: "Copy and share URL"