small refactor of RateLimiter for clarity

lib/rate_limiter.rb

@@ -21,18 +21,11 @@ class RateLimiter
   end
 
   def can_perform?
-    return true if RateLimiter.disabled?
+    rate_unlimited? || is_under_limit?
-    return true if @user.staff?
-
-    result = $redis.get(@key)
-    return true if result.blank?
-    return true if result.to_i < @max
-    false
   end
 
   def performed!
-    return if RateLimiter.disabled?
+    return if rate_unlimited?
-    return if @user.staff?
 
     result = $redis.incr(@key).to_i
     $redis.expire(@key, @secs) if result == 1
@@ -50,4 +43,13 @@ class RateLimiter
     $redis.decr(@key)
   end
 
+  private
+
+  def is_under_limit?
+    $redis.get(@key).to_i < @max
+  end
+
+  def rate_unlimited?
+    !!(RateLimiter.disabled? || @user.staff?)
+  end
 end