From 24f3b7854845eb4ddd2c4adb1ade9cb4e55efcfa Mon Sep 17 00:00:00 2001
From: Guo Xiang Tan <tgx_world@hotmail.com>
Date: Tue, 27 Feb 2018 10:12:22 +0800
Subject: [PATCH] Fix incorrect ids for 2FA inputs.

---
 .../discourse/templates/components/second-factor-input.hbs    | 2 +-
 .../javascripts/discourse/templates/mobile/modal/login.hbs    | 2 +-
 app/assets/javascripts/discourse/templates/modal/login.hbs    | 2 +-
 .../discourse/templates/preferences-second-factor.hbs         | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/discourse/templates/components/second-factor-input.hbs b/app/assets/javascripts/discourse/templates/components/second-factor-input.hbs
index a6aeda1a980..6cd05a616b9 100644
--- a/app/assets/javascripts/discourse/templates/components/second-factor-input.hbs
+++ b/app/assets/javascripts/discourse/templates/components/second-factor-input.hbs
@@ -2,7 +2,7 @@
     type="tel"
     pattern='[0-9]{6}'
     maxlength='6'
-    id="login-second-factor"
+    id=inputId
     autocorrect="off"
     autocapitalize="off"
     autofocus="autofocus"}}
diff --git a/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs b/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
index eb36a6ff6dc..2c9dc879a8d 100644
--- a/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
+++ b/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
@@ -45,7 +45,7 @@
           </table>
         </div>
         {{#second-factor-form}}
-          {{second-factor-input value=loginSecondFactor}}
+          {{second-factor-input value=loginSecondFactor inputId='login-second-factor'}}
         {{/second-factor-form}}
       </form>
     {{/if}}
diff --git a/app/assets/javascripts/discourse/templates/modal/login.hbs b/app/assets/javascripts/discourse/templates/modal/login.hbs
index ab877c95354..35f7015629c 100644
--- a/app/assets/javascripts/discourse/templates/modal/login.hbs
+++ b/app/assets/javascripts/discourse/templates/modal/login.hbs
@@ -34,7 +34,7 @@
           </table>
         </div>
         {{#second-factor-form}}
-          {{second-factor-input value=loginSecondFactor}}
+          {{second-factor-input value=loginSecondFactor inputId='login-second-factor'}}
         {{/second-factor-form}}
       </form>
     {{/if}}
diff --git a/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs b/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs
index 528b249ebcf..9df31c26656 100644
--- a/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs
+++ b/app/assets/javascripts/discourse/templates/preferences-second-factor.hbs
@@ -19,7 +19,7 @@
 
       <div class="control-group">
         <div class="controls">
-          {{second-factor-input value=secondFactorToken}}
+          {{second-factor-input value=secondFactorToken inputId='second-factor-token'}}
         </div>
 
         <div class='instructions'>
@@ -65,7 +65,7 @@
           <label class="control-label input-prepend">{{i18n 'login.second_factor_label'}}</label>
 
           <div class="controls">
-            {{second-factor-input value=secondFactorToken}}
+            {{second-factor-input value=secondFactorToken inputId='second-factor-token'}}
           </div>
         </div>