FIX: Use only first line from commit message (#18724)

Linking a commit from a GitHub pull request included the complete commit
message, instead of just the first line. The rest of the commit message
will be added to the body of the Onebox.
This commit is contained in:
Bianca Nenciu 2022-10-24 22:26:48 +03:00 committed by GitHub
parent f4c70283f7
commit 266e165885
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions

View File

@ -40,7 +40,7 @@ module Onebox
result['body'], result['excerpt'] = compute_body(result['body'])
if result['commit'] = load_commit(link)
result['body'], result['excerpt'] = compute_body(result['commit']['body'])
result['body'], result['excerpt'] = compute_body(result['commit']['commit']['message'].lines[1..].join)
elsif result['comment'] = load_comment(link)
result['body'], result['excerpt'] = compute_body(result['comment']['body'])
elsif result['discussion'] = load_review(link)

View File

@ -26,7 +26,7 @@
<div class="github-info-container">
{{#commit}}
<h4>
<a href="{{link}}" target="_blank" rel="noopener">{{commit.message}}</a>
<a href="{{link}}" target="_blank" rel="noopener">{{commit.message.lines.first}}</a>
</h4>
<span>

View File

@ -59,7 +59,9 @@ RSpec.describe Onebox::Engine::GithubPullRequestOnebox do
end
it "includes commit name" do
expect(html).to include("Add audio onebox")
doc = Nokogiri::HTML5(html)
expect(doc.css('h4').text.strip).to eq("Add audio onebox")
expect(doc.css('.github-body-container').text).to include("http://meta.discourse.org/t/audio-html5-tag/8168")
end
end